Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gap in GUI when viewloan <index> is called #109

Conversation

marcus-ny
Copy link

@marcus-ny marcus-ny commented Apr 4, 2024

Fixes #98

Changelog

  • Implement an extra setting in Model to allow for dual panel view
  • New variable isPersonTab added to Model. Since these BooleanProperties are becoming repetitive, we can refactor this by encapsulating all these tab properties into a single object in the coming interations

Note:

Seems to have fixed #106 as well (visually on the GUI). need confirming and testing. Likely will need more changes for this since the background list might still be populated when it shouldn't be.

@marcus-ny marcus-ny added the priority.High Must do label Apr 4, 2024
@marcus-ny marcus-ny added this to the v1.3 milestone Apr 4, 2024
@marcus-ny marcus-ny self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 46.76%. Comparing base (f504e9d) to head (64ab6f7).

Files Patch % Lines
src/main/java/seedu/address/ui/MainWindow.java 0.00% 19 Missing ⚠️
...rc/main/java/seedu/address/model/ModelManager.java 44.44% 9 Missing and 1 partial ⚠️
...rc/main/java/seedu/address/logic/LogicManager.java 0.00% 1 Missing ⚠️
.../seedu/address/logic/commands/ViewLoanCommand.java 0.00% 1 Missing ⚠️
...seedu/address/logic/commands/ViewLoansCommand.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #109      +/-   ##
============================================
- Coverage     47.11%   46.76%   -0.36%     
- Complexity      431      432       +1     
============================================
  Files            99       99              
  Lines          2235     2269      +34     
  Branches        224      227       +3     
============================================
+ Hits           1053     1061       +8     
- Misses         1138     1163      +25     
- Partials         44       45       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Joseph31416 Joseph31416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Joseph31416 Joseph31416 merged commit 376b672 into AY2324S2-CS2103T-W13-1:master Apr 4, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI bug when markloan is called in contacts view page Fix GUI display inconsistencies
2 participants