Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message cosmetic bugs #193

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Fix message cosmetic bugs #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ab429f
Merge remote-tracking branch 'upstream/master'
xiaorui-ui Apr 9, 2024
22e5ee8
Update help window url
xiaorui-ui Apr 10, 2024
df573a9
Update linkloan error message
xiaorui-ui Apr 10, 2024
735807a
Update all loan error messages for consistency
xiaorui-ui Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/seedu/address/logic/commands/DeleteLoanCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@ public class DeleteLoanCommand extends Command {
public static final String COMMAND_WORD = "deleteloan";

public static final String MESSAGE_USAGE = COMMAND_WORD
+ ": Delete the loan number of current person in view "
+ "Parameters: INDEX\n"
+ "INDEX must be a positive integer.\n"
+ ": Delete the loan number of current person in view. \n"
+ "Parameters: INDEX (must be a positive integer)\n"
+ "Example: " + COMMAND_WORD + " 1 ";
public static final String MESSAGE_SUCCESS = "Loan deleted.\n"
+ "Loan: %1$s";
Expand Down
1 change: 1 addition & 0 deletions src/main/java/seedu/address/logic/commands/EditLoanCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public class EditLoanCommand extends Command {
+ "[" + PREFIX_VALUE + "VALUE] "
+ "[" + PREFIX_START_DATE + "START_DATE] "
+ "[" + PREFIX_RETURN_DATE + "RETURN_DATE]\n"
+ "INDEX must be a positive integer.\n"
+ "Example: " + COMMAND_WORD + " "
+ "5 "
+ PREFIX_VALUE + "500.00 "
Expand Down
8 changes: 6 additions & 2 deletions src/main/java/seedu/address/logic/commands/LinkLoanCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,21 @@ public class LinkLoanCommand extends Command {
public static final String COMMAND_WORD = "linkloan";

public static final String MESSAGE_USAGE = COMMAND_WORD + ": Links a loan to the person identified "
+ "by the index number used in the displayed person list. "
+ "by the index number used in the displayed person list. \n"
+ "Parameters: "
+ "INDEX "
+ PREFIX_VALUE + "VALUE "
+ PREFIX_START_DATE + "START_DATE "
+ PREFIX_RETURN_DATE + "RETURN_DATE\n"
+ "INDEX must be a positive integer.\n"
+ "Example: " + COMMAND_WORD + " "
+ "5 "
+ PREFIX_VALUE + "500.00 "
+ PREFIX_START_DATE + "2024-02-15 "
+ PREFIX_RETURN_DATE + "2024-04-21";
+ PREFIX_RETURN_DATE + "2024-04-21\n"
+ "This links a loan to the 5th person in view with a value of $500, "
+ "a start date of 15 Feb 2024 "
+ "and an end date of 21 April 2024.";

public static final String MESSAGE_SUCCESS = "New loan linked to: %1$s\n"
+ "%2$s";
Expand Down
8 changes: 3 additions & 5 deletions src/main/java/seedu/address/logic/commands/MarkLoanCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@
public class MarkLoanCommand extends Command {
public static final String COMMAND_WORD = "markloan";
public static final String MESSAGE_USAGE = COMMAND_WORD
+ ": Marks the loan number of current person in view as paid.\n"
+ "Parameters: INDEX\n"
+ "INDEX must be a positive integer.\n"
+ "Example: " + COMMAND_WORD + " 1\n"
+ "This marks the loan of loan index 1 of the current person.";
+ ": Marks the current person in view's loan(of loan number) as paid.\n"
+ "Parameters: INDEX (must be a positive integer)\n"
+ "Example: " + COMMAND_WORD + " 1\n";
public static final String MESSAGE_SUCCESS = "Loan marked.\n"
+ "Loan: %1$s";
public static final String MESSAGE_FAILURE_LOAN = "No loan has been found "
Expand Down
8 changes: 3 additions & 5 deletions src/main/java/seedu/address/logic/commands/UnmarkLoanCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,9 @@
public class UnmarkLoanCommand extends Command {
public static final String COMMAND_WORD = "unmarkloan";
public static final String MESSAGE_USAGE = COMMAND_WORD
+ ": Marks the loan number of current person in view as paid.\n"
+ "Parameters: INDEX\n"
+ "INDEX must be a positive integer.\n"
+ "Example: " + COMMAND_WORD + " 1\n"
+ "This marks the loan of loan index 1 of the current person.";
+ ": Marks the current person in view's loan(of loan number) as not paid.\n"
+ "Parameters: INDEX (must be a positive integer)\n"
+ "Example: " + COMMAND_WORD + " 1\n";
public static final String MESSAGE_SUCCESS = "Loan unmarked.\n"
+ "Loan: %1$s";
public static final String MESSAGE_FAILURE_LOAN = "No loan has been found "
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/seedu/address/ui/HelpWindow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
public class HelpWindow extends UiPart<Stage> {

public static final String USERGUIDE_URL = "https://se-education.org/addressbook-level3/UserGuide.html";
public static final String USERGUIDE_URL = "https://ay2324s2-cs2103t-w13-1.github.io/tp/UserGuide.html";
public static final String HELP_MESSAGE = "Refer to the user guide: " + USERGUIDE_URL;

private static final Logger logger = LogsCenter.getLogger(HelpWindow.class);
Expand Down
Loading