Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics command #86

Conversation

marcus-ny
Copy link

No description provided.

@marcus-ny marcus-ny added the priority.High Must do label Mar 30, 2024
@marcus-ny marcus-ny added this to the v1.3 milestone Mar 30, 2024
@marcus-ny marcus-ny requested a review from Joseph31416 March 30, 2024 11:05
@marcus-ny marcus-ny self-assigned this Mar 30, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 53.86%. Comparing base (5c1b43b) to head (4c285bb).

Files Patch % Lines
...seedu/address/logic/commands/AnalyticsCommand.java 0.00% 20 Missing ⚠️
...u/address/logic/parser/AnalyticsCommandParser.java 0.00% 5 Missing ⚠️
.../seedu/address/logic/parser/AddressBookParser.java 0.00% 1 Missing ⚠️
src/main/java/seedu/address/model/AddressBook.java 66.66% 1 Missing ⚠️
...rc/main/java/seedu/address/model/ModelManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
- Coverage     54.63%   53.86%   -0.78%     
  Complexity      429      429              
============================================
  Files            90       92       +2     
  Lines          1898     1927      +29     
  Branches        181      183       +2     
============================================
+ Hits           1037     1038       +1     
- Misses          819      847      +28     
  Partials         42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Joseph31416 Joseph31416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -0,0 +1,66 @@
package seedu.address.logic.commands;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with the other command files.

@Joseph31416 Joseph31416 merged commit 939ccb9 into AY2324S2-CS2103T-W13-1:master Mar 30, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants