Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new flag for viewloan and merge viewloans into viewloan #91

Merged

Conversation

narwhalsilent
Copy link

@narwhalsilent narwhalsilent commented Apr 1, 2024

Fix #90. Refer to the issue page for more information.

@narwhalsilent narwhalsilent added the priority.High Must do label Apr 1, 2024
@narwhalsilent narwhalsilent added this to the v1.3 milestone Apr 1, 2024
@narwhalsilent narwhalsilent self-assigned this Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 53.36%. Comparing base (939ccb9) to head (fb7601f).
Report is 2 commits behind head on master.

Files Patch % Lines
...du/address/logic/parser/ViewLoanCommandParser.java 0.00% 10 Missing ⚠️
...seedu/address/logic/commands/ViewLoansCommand.java 0.00% 5 Missing ⚠️
.../seedu/address/logic/commands/ViewLoanCommand.java 0.00% 4 Missing ⚠️
...address/logic/commands/ViewLoanRelatedCommand.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #91      +/-   ##
============================================
- Coverage     53.86%   53.36%   -0.51%     
  Complexity      429      429              
============================================
  Files            92       93       +1     
  Lines          1927     1947      +20     
  Branches        183      191       +8     
============================================
+ Hits           1038     1039       +1     
- Misses          847      866      +19     
  Partials         42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@marcus-ny marcus-ny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor nit with access modifier.

Have tested the command and works without any errors. Seems gtg!

*/
public abstract class ViewLoanRelatedCommand extends Command {
public static final String COMMAND_WORD = "viewloan";
final boolean isShowAllLoans;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might be better to use explicit access modifier

Copy link

@marcus-ny marcus-ny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm!

@marcus-ny marcus-ny merged commit b3082ed into AY2324S2-CS2103T-W13-1:master Apr 2, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add view all loans tag
2 participants