-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new flag for viewloan and merge viewloans into viewloan #91
Add new flag for viewloan and merge viewloans into viewloan #91
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
============================================
- Coverage 53.86% 53.36% -0.51%
Complexity 429 429
============================================
Files 92 93 +1
Lines 1927 1947 +20
Branches 183 191 +8
============================================
+ Hits 1038 1039 +1
- Misses 847 866 +19
Partials 42 42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor nit with access modifier.
Have tested the command and works without any errors. Seems gtg!
*/ | ||
public abstract class ViewLoanRelatedCommand extends Command { | ||
public static final String COMMAND_WORD = "viewloan"; | ||
final boolean isShowAllLoans; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: might be better to use explicit access modifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm!
Fix #90. Refer to the issue page for more information.