Add personal tasks #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the Task class to represent the tasks for the user to add to the app.
Let's create an AddTaskCommand class to represent the command that adds a task to the book. Let's create an AddTaskCommand Parser class to process the user input for an add task command.
Create the TaskList class to store the tasks from users.
Update AddressBookParser.parseCommand() to recognize the addtask keyword. Modify AddTaskCommandParser.java to parse user input. Modify AddTaskCommand.java to add task to the task list. Update TaskList.java to include methods to add class and to check duplicate tasks. Update ModelManager.java and MainApp.java to include TaskList in the constructor. Update Messages.java to include the method for formatting task description.
Create TaskList Storage to store tasks into the data file. Create Json adapted classes to store tasks in a Json file.
Let's update the Storage package to store the task list in the json data file. Let's update the model package to contain the task list. Let's update the logic package to save the tasks to the task list.
Change the test files to include the task list in model and storage classes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34 +/- ##
============================================
+ Coverage 75.26% 75.40% +0.14%
- Complexity 419 463 +44
============================================
Files 71 78 +7
Lines 1338 1472 +134
Branches 126 134 +8
============================================
+ Hits 1007 1110 +103
- Misses 301 330 +29
- Partials 30 32 +2 ☔ View full report in Codecov by Sentry. |
Add test classes for new classes and methods. Update old tests in ModelManagerTest and StorageManager to test TaskList methods.
Add more test classes for new classes and methods.
Add more tests for more methods.
Add test to taskList methods in StorageManager.
Fix tests for taskList methods in StorageManager.
Add more test classes for new classes and methods.
|
Looks good to me! |
|
Looks great! Would be good to include a task name for the task. |
chin-herng
approved these changes
Mar 15, 2024
| /** | ||
| * Formats the {@code task} for display to the user. | ||
| */ | ||
| public static String formatTask(Task task) { |
There was a problem hiding this comment.
nit-pick, might be better to just overload the format(Person) method and name this format as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a student, I can add personal tasks, so that I can keep up to date with the different tasks to complete.