Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Developer Guide for the Storage component #63

Conversation

Kaya3842
Copy link

@Kaya3842 Kaya3842 commented Apr 4, 2024

Update StorageClassDiagram.puml to incorporate TaskList in the UML Diagram.

Update DeveloperGuide.md for the Storage component to include TaskList classes.

Update StorageClassDiagram.puml to incorporate TaskList in the
UML Diagram.

Update DeveloperGuide.md for the Storage component to include TaskList
classes.
@Kaya3842 Kaya3842 added the documentation Improvements or additions to documentation label Apr 4, 2024
@Kaya3842 Kaya3842 added this to the v1.3 milestone Apr 4, 2024
@Kaya3842 Kaya3842 self-assigned this Apr 4, 2024
Copy link

@breezetall breezetall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.88%. Comparing base (d0f6434) to head (643aba4).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #63   +/-   ##
=========================================
  Coverage     79.88%   79.88%           
  Complexity      682      682           
=========================================
  Files           104      104           
  Lines          2118     2118           
  Branches        215      215           
=========================================
  Hits           1692     1692           
  Misses          378      378           
  Partials         48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@nobodyishappy nobodyishappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@Yskie Yskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looooks goooood to me!

Copy link

@chin-herng chin-herng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chin-herng chin-herng merged commit cf20f4c into AY2324S2-CS2103T-W13-4:master Apr 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants