Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in _parallel_kf_mf.build_block_diag, use block_index not 0 #21

Merged
merged 1 commit into from
May 4, 2023

Conversation

fsaad
Copy link
Contributor

@fsaad fsaad commented May 2, 2023

Using Pzeros.at[0] gives a dimension error. All other instances of "Pzeros.at" in this module use Pzeros.at[block_index] instead of Pzeros.at[0], and it appears to solve the problem.

…of 0.

Using Pzeros.at[0] gives a dimension error.  All other instances of
"Pzeros.at" in this module use Pzeros.at[block_index] instead of Pzeros.at[0].
Copy link
Collaborator

@wil-j-wil wil-j-wil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good catch. This bug was introduced when we updated to use the new jax .at[] functionality. The old version did indeed index at the block_index.

@wil-j-wil wil-j-wil merged commit ebd941d into AaltoML:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants