Skip to content

Commit

Permalink
Deflake metrics expiration test (istio#17201)
Browse files Browse the repository at this point in the history
  • Loading branch information
howardjohn authored and geeknoid committed Sep 22, 2019
1 parent 495a2b4 commit 596e743
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions mixer/adapter/prometheus/prometheus_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -532,11 +532,11 @@ func TestMetricExpiration(t *testing.T) {
checkWaitTime time.Duration
}{
{"No expiration", metricInfos{counter}, metricInsts{counterVal}, metricInsts{}, nil, 0},
{"Single metric expiration (counter)", metricInfos{counter}, metricInsts{counterVal}, metricInsts{}, testPolicy, 100 * time.Millisecond},
{"Single metric expiration (counter, alt policy)", metricInfos{counter}, metricInsts{counterVal}, metricInsts{}, altPolicy, 100 * time.Millisecond},
{"Single metric expiration (gauge)", metricInfos{gaugeWithLabels}, metricInsts{gaugeWithLabelsVal}, metricInsts{}, testPolicy, 100 * time.Millisecond},
{"Single metric expiration (histogram)", metricInfos{histogram}, metricInsts{histogramVal}, metricInsts{}, testPolicy, 100 * time.Millisecond},
{"Preserve non-stale metrics", metricInfos{counter}, metricInsts{counterVal}, metricInsts{counterVal2}, testPolicy, 100 * time.Millisecond},
{"Single metric expiration (counter)", metricInfos{counter}, metricInsts{counterVal}, metricInsts{}, testPolicy, 200 * time.Millisecond},
{"Single metric expiration (counter, alt policy)", metricInfos{counter}, metricInsts{counterVal}, metricInsts{}, altPolicy, 200 * time.Millisecond},
{"Single metric expiration (gauge)", metricInfos{gaugeWithLabels}, metricInsts{gaugeWithLabelsVal}, metricInsts{}, testPolicy, 200 * time.Millisecond},
{"Single metric expiration (histogram)", metricInfos{histogram}, metricInsts{histogramVal}, metricInsts{}, testPolicy, 200 * time.Millisecond},
{"Preserve non-stale metrics", metricInfos{counter}, metricInsts{counterVal}, metricInsts{counterVal2}, testPolicy, 200 * time.Millisecond},
}

f := newBuilder(&testServer{})
Expand Down

0 comments on commit 596e743

Please sign in to comment.