Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: strip <em> tags before rendering math blocks #2

Merged
merged 5 commits into from
Sep 7, 2020
Merged

fix: strip <em> tags before rendering math blocks #2

merged 5 commits into from
Sep 7, 2020

Conversation

AaronCQL
Copy link
Owner

@AaronCQL AaronCQL commented Sep 7, 2020

  • Common problematic latex syntax include }_ and ^*, which GitHub will parse as }<em> and ^<em> respectively
  • This fix finds in the DOM all instances of }<em> and ^<em>, and the corresponding closing </em> and replaces them appropriately
  • Has potential to cause problems since all instances, instead of only those in math blocks are replaced

Fixes #1.

@AaronCQL AaronCQL merged commit 6ef2f27 into master Sep 7, 2020
@AaronCQL AaronCQL mentioned this pull request Sep 9, 2020
Merged
@AaronCQL AaronCQL deleted the em-fix branch October 27, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parenthesis and underscore doesn't work?
1 participant
@AaronCQL