Drop support for Ruby 1.9.3 #344
Conversation
|
We never officially supported JRuby or Rubinius. Should we remove them from the Travis build matrix? |
|
I'd like to continue supporting JRuby. It's a reasonable and used alternative to MRI. Rubinius I could live without. |
|
Can you figure out how to get JRuby running in Ruby 2.0 mode on Travis then? |
|
Sure, I'll look into it. |
|
Might be as easy as `JRUBY_OPTS='--2.0'. |
|
Well that was unexpected: https://travis-ci.org/orgsync/active_interaction/jobs/101112443 |
JRuby 9000
| send("#{name}=", value) | ||
| end unless method_defined?(:[]=) | ||
| end | ||
|
|
There was a problem hiding this comment.
I thought the plan was to avoid backward incompatible changes for now.
There was a problem hiding this comment.
As a note I'm fine with dropping 1.9.3 like a bad habit.
There was a problem hiding this comment.
I planned on leaving this in. When I changed the gem spec to require Ruby >= 2, I realized that this served absolutely no purpose. If we wanted to continue to unofficially support Ruby 1.9.3, we'd need to keep Ruby >= 1.9.3 in the gem spec. And that basically means officially supporting Ruby 1.9.3, which defeats the whole point.
All that to say, I've changed my mind. I'm fine with dropping support for 1.9.3. If someone wants to use ActiveInteraction on 1.9.3, they need to use some version < 3.
|
|
Fixes #343.