-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for ActiveModel 3.2 #346
Conversation
I would like to replace if spec.version_of 'active_model' < 5
spec.add_dependency 'active_model-errors_details', '~> 1.3'
end But I don't know how to do that. I don't even know if it's possible. |
I have no idea how to do that. |
If I had to guess, I'd say it's not possible. I poked around a little in I'm ok with leaving |
|
||
{ | ||
'actionpack' => ['>= 3.2', '< 6'], | ||
'actionpack' => [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. No need to repeat the version numbers.
|
It looks like we can also drop the |
Drop support for ActiveModel 3.2
Fixes #345.