Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for ActiveModel 3.2 #346

Merged
merged 2 commits into from
Jan 10, 2016
Merged

Drop support for ActiveModel 3.2 #346

merged 2 commits into from
Jan 10, 2016

Conversation

tfausak
Copy link
Collaborator

@tfausak tfausak commented Jan 8, 2016

Fixes #345.

@tfausak tfausak self-assigned this Jan 8, 2016
@tfausak tfausak added this to the v3.0.0 milestone Jan 8, 2016
@tfausak
Copy link
Collaborator Author

tfausak commented Jan 8, 2016

I would like to replace ActiveInteraction::Errors::Details with active_model-errors_details, but that gem doesn't work with Rails 5. I want to add something like this to our gem spec:

if spec.version_of 'active_model' < 5
  spec.add_dependency 'active_model-errors_details', '~> 1.3'
end

But I don't know how to do that. I don't even know if it's possible.

@AaronLasseigne
Copy link
Owner

I have no idea how to do that.

@tfausak
Copy link
Collaborator Author

tfausak commented Jan 8, 2016

If I had to guess, I'd say it's not possible. I poked around a little in Gem::Specification and Gem::Dependency and didn't find anything helpful.

I'm ok with leaving ActiveInteraction::Errors::Details in there. We can drop it when we drop support for Rails < 5 😉

@tfausak tfausak mentioned this pull request Jan 8, 2016

{
'actionpack' => ['>= 3.2', '< 6'],
'actionpack' => [],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. No need to repeat the version numbers.

@AaronLasseigne
Copy link
Owner

:shipit:

@AaronLasseigne
Copy link
Owner

It looks like we can also drop the HashFilter code in the backport. It's Rails < 4.0.0.

tfausak added a commit that referenced this pull request Jan 10, 2016
Drop support for ActiveModel 3.2
@tfausak tfausak merged commit 4485767 into master Jan 10, 2016
@tfausak tfausak deleted the gh-345-rails branch January 10, 2016 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants