Allow ActionController::Parameters as inputs #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #381.
|
Can you review this, @AaronLasseigne? Here are links to relevant documentation in Rails: |
| klass = 'ActionController::Parameters'.safe_constantize | ||
| if !klass || !inputs.is_a?(klass) | ||
| raise ArgumentError, 'inputs must be a hash' | ||
| end |
There was a problem hiding this comment.
Right now the code goes, good, bad, good. It might work better to group the good paths.
return inputs if inputs.is_a?(Hash)
klass = 'ActionController::Parameters'.safe_constantize
if klass && inputs.is_a?(klass)
return inputs.to_unsafe_h
end
raise ArgumentError, 'inputs must be a hash'
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #381.