Add a base option to integer filters #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #386.
|
@AaronLasseigne can you review this? |
|
Thanks for the PR! Just a thought: I would imagine everyone out there would now have to add base 10 to their interactions...since it's 99% of the use case out there. I believe this is the same reason JavaScript made base 10 the default for |
|
Forgot my point: Should we default it to base 10? |
|
I would like to make |
|
I see, makes sense. Can we be sure to make the default 10 on the next "backwards-compability breaking" release? |
|
Code looks great. We need to add some docs on it to the README. |
ngan
added a commit
to ngan/active_interaction
that referenced
this pull request
Oct 19, 2016
This accompanies AaronLasseigne#387
Add README update in #391. Thanks! Let's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #386.