Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle -iquote flag and only write relative target_include_directories() for project dirs #25

Merged
merged 2 commits into from
Jul 24, 2018

Conversation

arichardson
Copy link
Contributor

No description provided.

Also only add the SYSTEM and BEFORE target_include_directories() if there
was at least one entry since otherwise CMake complains.
For paths that are not below the source root write the absolute path
in the target_include_directories instead of ../../../usr/local/include
Copy link
Owner

@AbigailBuccaneer AbigailBuccaneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Owner

@AbigailBuccaneer AbigailBuccaneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@AbigailBuccaneer AbigailBuccaneer merged commit caaeb17 into AbigailBuccaneer:master Jul 24, 2018
AbigailBuccaneer added a commit that referenced this pull request Jul 24, 2018
#25 accidentally removed this line.
@AbigailBuccaneer AbigailBuccaneer mentioned this pull request Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants