Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CodeNarc to 3.4.0 #411

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Update CodeNarc to 3.4.0 #411

merged 3 commits into from
Jan 16, 2024

Conversation

nre-ableton
Copy link
Contributor

  • Update CodeNarc to 3.4.0
  • Version 0.14.6

@nre-ableton nre-ableton marked this pull request as ready for review January 15, 2024 13:21
@nre-ableton nre-ableton requested a review from a team as a code owner January 15, 2024 13:21
@nre-ableton nre-ableton requested review from mst-ableton and removed request for a team January 15, 2024 13:21
@nre-ableton nre-ableton changed the base branch from master to main January 15, 2024 15:39
@nre-ableton nre-ableton mentioned this pull request Jan 16, 2024
Closed
@mst-ableton
Copy link
Contributor

I think something went wrong here... you have a merge commit instead of having 7fa261f on its own. Other than that it looks good.

@nre-ableton
Copy link
Contributor Author

I think something went wrong here... you have a merge commit instead of having 7fa261f on its own. Other than that it looks good.

This happened when I used GitHub to change the base branch. I'll see what I can do to fix this.

@nre-ableton nre-ableton force-pushed the nre/master/codenarc-3.4.0 branch from 1b4d27b to 540a611 Compare January 16, 2024 10:40
@nre-ableton nre-ableton force-pushed the nre/master/codenarc-3.4.0 branch from 540a611 to 12cab29 Compare January 16, 2024 10:41
mst-ableton
mst-ableton approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@mst-ableton mst-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@nre-ableton nre-ableton merged commit 637c8a7 into main Jan 16, 2024
4 checks passed
@nre-ableton nre-ableton deleted the nre/master/codenarc-3.4.0 branch January 16, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mst-ableton mst-ableton mst-ableton approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nre-ableton @mst-ableton