#101: ErrorHandling documentation and fields renames #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new functions `null_col` and `call_udf` * `ErrorMessage` refactoring * `ErrorHandling` trait designed to serve as the interface for different implementations * Implement error handling by putting the info into column of `ErrorMessage` array * numerous support classes
…e of raw values * `ErrorMessageSubmitJustErrorValue` class created to offer the ability to submit errors without source column but with error value
* `ErrorMessageSubmitWithoutColumn` changed from `case class` to `class` to allow inheritance * some PR comments addressed
…or-handling-map-errcol Introducing Map for error columns and their values
* Fixed few minor things discovered by the UTs
…dling/implementations/ErrorMessageArray.scala Co-authored-by: Ladislav Sulak <[email protected]>
* merged `ErrorHandlingCommon` into `ErrorHandling` * renamed errCol / errCols => errSrcColName * renamed putErrorToColumn => createErrorAsColumn * renamed aggregateErrorColumns => applyErrorColumnsToDataFrame * renamed `EvaluateIntoErrorMessage` to `TransformIntoErrorMessage` * renamed `EvaluateViaUdf` to `TransformViaUdf` * some smaller parameters renamed * numerous ScalaDoc entries
benedeki
requested review from
TebaleloS,
miroslavpojer and
dk1844
and removed request for
dk1844,
lsulak,
Zejnilovic and
TebaleloS
lsulak
reviewed
May 4, 2023
...sa/spark/commons/errorhandling/implementations/submits/ErrorMessageSubmitOnMoreColumns.scala
Show resolved
Hide resolved
lsulak
reviewed
May 4, 2023
spark-commons/src/main/scala/za/co/absa/spark/commons/errorhandling/types/ErrorWhen.scala
Outdated
Show resolved
Hide resolved
* typo fix * enhanced information about partials
JaCoCo code coverage report - scala:2.12 - spark:3.3
|
lsulak
reviewed
May 5, 2023
...sa/spark/commons/errorhandling/implementations/submits/ErrorMessageSubmitWithoutColumn.scala
Outdated
Show resolved
Hide resolved
lsulak
reviewed
May 5, 2023
...park/commons/errorhandling/implementations/submits/ErrorMessageSubmitWithoutColumnTest.scala
Show resolved
Hide resolved
lsulak
reviewed
May 5, 2023
* documentation to `ErrorMessageArray` * `null_col` function description enhanced
lsulak
reviewed
May 6, 2023
...rc/main/scala/za/co/absa/spark/commons/errorhandling/implementations/ErrorMessageArray.scala
Outdated
Show resolved
Hide resolved
lsulak
reviewed
May 6, 2023
lsulak
reviewed
May 9, 2023
...park/commons/errorhandling/implementations/submits/ErrorMessageSubmitWithoutColumnTest.scala
Show resolved
Hide resolved
lsulak
previously approved these changes
May 12, 2023
TebaleloS
previously approved these changes
May 15, 2023
build.sbt
Outdated
| lazy val commonJacocoExcludes: Seq[String] = Seq( | ||
| "za.co.absa.spark.commons.adapters.CallUdfAdapter", | ||
| "za.co.absa.spark.commons.adapters.TransformAdapter" | ||
| // "za.co.absa.spark.commons.utils.JsonUtils*", // class and related objects |
There was a problem hiding this comment.
I see dead code, is reserved for something or can removed
There was a problem hiding this comment.
Still here (and 1 below)
build.sbt
Outdated
| "za.co.absa.spark.commons.adapters.CallUdfAdapter", | ||
| "za.co.absa.spark.commons.adapters.TransformAdapter" | ||
| // "za.co.absa.spark.commons.utils.JsonUtils*", // class and related objects | ||
| // "za.co.absa.spark.commons.utils.ExplodeTools" // class only |
There was a problem hiding this comment.
The example with * is still hint.
There was a problem hiding this comment.
I will actually change it to make it obvious it's a documentation and not dead code 😉
…d-fields-renames # Conflicts solved: # spark-commons/src/main/scala/za/co/absa/spark/commons/errorhandling/ErrorHandling.scala # spark-commons/src/main/scala/za/co/absa/spark/commons/errorhandling/implementations/ErrorHandlingFilterRowsWithErrors.scala # spark-commons/src/main/scala/za/co/absa/spark/commons/errorhandling/partials/ErrorHandlingCommon.scala # spark-commons/src/test/scala/za/co/absa/spark/commons/errorhandling/implementations/ErrorMessageArrayTest.scala
lsulak
reviewed
Jun 20, 2023
lsulak
approved these changes
Jun 20, 2023
benedeki
deleted the
feature/101-errorhandling-documentation-and-fields-renames
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrorHandlingCommonintoErrorHandlingEvaluateIntoErrorMessagetoTransformIntoErrorMessageEvaluateViaUdftoTransformViaUdfDepends on #84Depends on #94Closes #101