Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: duplication of event handler #228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

intls
Copy link

@intls intls commented Feb 4, 2025

  1. The same event handler disconnect is registered twice.

  2. To ensure the correct state update, the call should be made with the await operator.


PR-Codex overview

This PR focuses on improving error handling and ensuring the activate method is awaited in the AbstractGlobalWallet class of the web3-react-agw package.

Detailed summary

  • Removed the disconnect event listener which reset the state and handled errors.
  • Changed the call to this.activate(desiredChainId) to await this.activate(desiredChainId) for proper asynchronous handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: 0d74521

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coffeexcoin coffeexcoin requested a review from ccummings February 4, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant