Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tx 0x00 #233

Merged
merged 4 commits into from
Feb 5, 2025
Merged

fix tx 0x00 #233

merged 4 commits into from
Feb 5, 2025

Conversation

coffeexcoin
Copy link
Collaborator

@coffeexcoin coffeexcoin commented Feb 5, 2025

  • fix(signTransaction): force undefined data to 0x so it isn't serialized to 0x00
  • changeset

PR-Codex overview

This PR addresses an issue where undefined data in transactions was being serialized to 0x00, causing problems when sending ETH to contracts without a fallback function. It ensures that if data is undefined, it is set to 0x instead.

Detailed summary

  • In signTransaction.ts, added a check for transactionWithPaymaster.data being undefined.
  • If data is undefined, it is now set to '0x' to prevent serialization issues.
  • Updated test cases in signTransaction.test.ts to reflect the change in data being set to '0x'.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@coffeexcoin coffeexcoin requested a review from cygaar as a code owner February 5, 2025 14:40
Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: f0fad86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@abstract-foundation/agw-client Patch
@abstract-foundation/agw-react Patch
@abstract-foundation/web3-react-agw Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
packages/agw-client/src/actions/signTransaction.ts 85.54% <100.00%> (+0.26%) ⬆️

@coffeexcoin coffeexcoin merged commit 30647bd into main Feb 5, 2025
6 checks passed
@coffeexcoin coffeexcoin deleted the fix-tx-0x00 branch February 5, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant