Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility document to visualize geometric nodes #1155

Closed
wants to merge 5 commits into from

Conversation

pablode
Copy link
Contributor

@pablode pablode commented Nov 25, 2022

This PR proposes a document that contains materials which visualize geometric properties as colors.

It can be used 1) to inspect and verify an asset's geometry (f.i. using MaterialXView) and 2) to compare the handling of geometric nodes across different MaterialX-supporting renderers (e.g. tangents in HdStorm).

The shader compilation error is fixed by commit 3c9996b769 (or PR #1156).

@kwokcb
Copy link
Contributor

kwokcb commented Nov 26, 2022

Hi @pablode ,
I'd suggest moving / merging this with what's in the unit test area here: https://github.com/AcademySoftwareFoundation/MaterialX/tree/main/resources/Materials/TestSuite/stdlib/geometric
as test files are kept there.

@jstone-lucasfilm
Copy link
Member

Agreed that it would be valuable to merge these new tests with the existing streams.mtlx example document, which has a similar goal of providing debug visualization of geometry nodes:

https://github.com/AcademySoftwareFoundation/MaterialX/blob/main/resources/Materials/TestSuite/stdlib/geometric/streams.mtlx

On the other hand, our existing examples are challenging for new developers to find, and perhaps there's a better home for them within the MaterialX resources folder structure? All ideas on this front are welcome.

@jstone-lucasfilm
Copy link
Member

@pablode I'll close out this issue for now, but feel free to propose improvements to the coverage and accessibility of streams.mtlx as needed in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants