Remove support for legacy OSL closures #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changelist removes support for the legacy (i.e. pre-v1.12) OSL closures, focusing exclusively on the MaterialX-synchronized OSL closures that were introduced to OSL in October 2022.
|
As a reference for reviewers, this change was discussed and approved in our MaterialX TSC meeting on November 19th. |
niklasharrysson
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
This looks good to me @jstone-lucasfilm. Nice to get this cleaned up!
|
Thanks @niklasharrysson! |
jstone-lucasfilm
merged commit cbd9177
into
AcademySoftwareFoundation:main
34 checks passed
jstone-lucasfilm
pushed a commit
that referenced
this pull request
Dec 14, 2024
#2121 removed the OSL legacy closures - but we can simplify the data library installation a little more now they are gone.
jstone-lucasfilm
added a commit
to jstone-lucasfilm/MaterialX
that referenced
this pull request
Dec 14, 2024
This changelist updates the minimum OSL version in our documentation to 1.12.6, mirroring recent codebase changes in AcademySoftwareFoundation#2121.
jstone-lucasfilm
added a commit
to jstone-lucasfilm/MaterialX
that referenced
this pull request
Dec 14, 2024
This changelist updates the minimum OSL version in our documentation to 1.12.6, mirroring the removal of legacy closure support in AcademySoftwareFoundation#2121.
jstone-lucasfilm
added a commit
to jstone-lucasfilm/MaterialX
that referenced
this pull request
Dec 14, 2024
This changelist updates the minimum OSL version in our documentation, mirroring recent codebase changes in AcademySoftwareFoundation#2121.
jstone-lucasfilm
added a commit
that referenced
this pull request
Dec 14, 2024
This changelist updates the minimum OSL version in our documentation, mirroring recent codebase changes in #2121.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changelist removes support for the legacy (i.e. pre-v1.12) OSL closures, focusing exclusively on the MaterialX-synchronized OSL closures that were introduced to OSL in October 2022.