Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of missing scenes in the Web Viewer #2124

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Fix handling of missing scenes in the Web Viewer #2124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f223348
Fix the handling of missing scene in GLTF files
samip Nov 27, 2024
3ca12a8
Merge branch 'main' into fix_js_viewer_missing_model_handling
jstone-lucasfilm Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions javascript/MaterialXView/source/viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@ export class Scene
}

this.#_rootNode = null;
const model = gltfData.scene;
let model = gltfData.scene;
if (!model)
{
const geometry = new THREE.BoxGeometry(1, 1, 1);
const material = new THREE.MeshBasicMaterial({ color: 0xdddddd });
const cube = new THREE.Mesh(geometry, material);
obj = new Group();
obj.add(geometry);
model = new Group();
model.add(cube);
jstone-lucasfilm marked this conversation as resolved.
Show resolved Hide resolved
}
else
{
Expand Down