Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latlongimage node #2168

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

pablode
Copy link
Contributor

@pablode pablode commented Jan 4, 2025

This PR proposes an initial version of a node that samples equiangular images.

Question: should the image framerange/frameoffset/frameendaction inputs be forwarded?

@jstone-lucasfilm jstone-lucasfilm changed the title Add <latlongimage> node Add latlongimage node Jan 12, 2025
@jstone-lucasfilm
Copy link
Member

This looks like a great step forward to me, @pablode, and I believe the testing errors just require the same fix as you implemented for fract, where each type variant of the new node has a single usage in our Materials/TestSuite folder.

@pablode
Copy link
Contributor Author

pablode commented Jan 24, 2025

Not sure about that, it seems rather an issue with the Unit system not being set up correctly in the test runner. (See log messages and 2nd commit succeeding.)

@jstone-lucasfilm
Copy link
Member

@pablode Ah, good catch, and I was making assumptions about these errors being the same as the ones in fract.

As a starting point, perhaps we should omit the new unit attribute in the latlongimage node, and we can log that as a future improvement that would be linked to updates to our test suite?

@pablode
Copy link
Contributor Author

pablode commented Jan 25, 2025

Sure, reverted the commit. Maybe in the future, this can be an 'idiomatic' MaterialX practice ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants