Integrate OSL class improvements #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changelist integrates recent improvements to the color4, vector2, and vector4 classes in the OSL project, including bug fixes for inequality tests. Further in the future, we can take the step of removing our local copy of these classes in the MaterialX project, relying fully on their OSL definitions.
|
Linking this PR to AcademySoftwareFoundation/OpenShadingLanguage#1892, where the latest improvements to these classes were introduced. |
|
Attaching a GLSL/OSL render comparison using the codebase in this PR: |
jstone-lucasfilm
merged commit d046beb
into
AcademySoftwareFoundation:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changelist integrates recent improvements to the color4, vector2, and vector4 classes in the OSL project, including bug fixes for inequality tests.
Further in the future, we can take the step of removing our local copy of these classes in the MaterialX project, relying fully on their OSL definitions.