Rqd multiple os #1566
Merged
Rqd multiple os #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When RUN_ON_DOCKER is set on rqd.conf, each frame will be launched as a docker container using the base image configured as DOCKER_IMAGE.
…le (AcademySoftwareFoundation#1542) - Updated `viewComments` method in `MenuActions.py` to wrap single Job objects in a list. - This prevents `TypeError` when attempting to iterate over a non-iterable Job object.
…on#1543) - Add `rocky9` log root to `render_logs.root` in `cuegui.yaml`
Logging was added on the wrong scope, which led to a "Frame not found in cache" when a frame was actually found.
New spec is required to allow passing the layer's expected OS.
When rqd is running on docker mode, it can report multiple supported OSs. On rqd.conf, multiple images can be provided under [docker.images] and each image refers to a supported OS.
Signed-off-by: Diego Tavares <[email protected]>
… directly (AcademySoftwareFoundation#1547) **Summarize your change.** Have changed most tests to use `-m unittest discover` instead og `setup.py test` The old `setup.py test` doesn't work in newer versions of python since it has been deprecated
Previously it was safe to use the host's OS when querying for procs, now the job OS needs to be used as a host can have multiple OSs.
…oundation#1554) Deleting an item from the dict being iterated over on sanitizeFrames caused the error: "Dictionary changed size during iteration".
To be able to run as the frame's owner, the entrypoint needs to ensure the user exists before running the frame's cmd.
…to3 (AcademySoftwareFoundation#1557) **Link the Issue(s) this Pull Request is related to.** This is to fix AcademySoftwareFoundation#1555 **Summarize your change.** Replaces 2to3 with a simple script that adds "from ." in front of pb2 imports. This is done to support newer versions of python where 2to3 has been removed.
Not having nimby installed is an expected event, not an exception.
…oundation#1559) **Link the Issue(s) this Pull Request is related to.** [cuegui] Cannot select and play multiple jobs and frames using viewers in OpenCue: AcademySoftwareFoundation#1558 **Summarize your change.** This fixes the changes in PR: AcademySoftwareFoundation#1513 - Fix multiple jobs and frames visualization with different viewers - Updated JobMonitorTree.py and FrameMonitorTree.py to enable select multiple jobs and multiple frames and play using the players (e.g., OpenRV, RV, Itview = SPI viewer) configured in `cuegui.yaml`, options `output_viewers` and `output_viewer_direct_cmd_call` - Enhanced cuegui.yaml to include configuration for multiple viewers. - Fix unit tests in `FrameMonitorTree_tests.py` > `test_rightClickItem()` to ensure the job attribute is set This change allows users to open multiple jobs (JobMonitorTree.py) and frames (FrameMonitorTree.py) using different configurable viewers. The option to open multiple layers (LayerMonitorTree.py) was working before and kept as it was.
…le (AcademySoftwareFoundation#1542) - Updated `viewComments` method in `MenuActions.py` to wrap single Job objects in a list. - This prevents `TypeError` when attempting to iterate over a non-iterable Job object.
…on#1543) - Add `rocky9` log root to `render_logs.root` in `cuegui.yaml`
… directly (AcademySoftwareFoundation#1547) **Summarize your change.** Have changed most tests to use `-m unittest discover` instead og `setup.py test` The old `setup.py test` doesn't work in newer versions of python since it has been deprecated
unittest was not reporting test failures and interruptions as expected, which caused us to be running with failed unit tests for a long time. This commit replaces unittest with pytest for rqd and fixes some of the relevant unit tests.
…oundation#1554) Deleting an item from the dict being iterated over on sanitizeFrames caused the error: "Dictionary changed size during iteration".
…to3 (AcademySoftwareFoundation#1557) **Link the Issue(s) this Pull Request is related to.** This is to fix AcademySoftwareFoundation#1555 **Summarize your change.** Replaces 2to3 with a simple script that adds "from ." in front of pb2 imports. This is done to support newer versions of python where 2to3 has been removed.
Since AcademySoftwareFoundation#1308 rqd stopped supporting stats files containing whitespaces and parenthesis.
When RUN_ON_DOCKER is set on rqd.conf, each frame will be launched as a docker container using the base image configured as DOCKER_IMAGE.
Signed-off-by: Diego Tavares <[email protected]>
Signed-off-by: Diego Tavares <[email protected]>
Signed-off-by: Diego Tavares <[email protected]>
…ype job attribute (AcademySoftwareFoundation#1561) - Ensure the job attribute is set before triggering the context menu event. - Mock the getLayers method to return an empty list to avoid NoneType errors.
When creating an user on a container, add a randomly generated password for security
Signed-off-by: Diego Tavares <[email protected]>
…ySoftwareFoundation#1564) **Link the Issue(s) this Pull Request is related to.** This fixes an bug introduced with AcademySoftwareFoundation#1554 **Summarize your change.** It fixes a small bug that hinders `rqd` to actually run any jobs. It probably didn't get chaught due to the unittests for rqd not working properly.
Signed-off-by: Diego Tavares <[email protected]>
DiegoTavares
requested review from
bcipriano and
ramonfigueiredo
as code owners
DiegoTavares
merged commit f1623dc
into
AcademySoftwareFoundation:containerized_rqd
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update temporary sync branch