Disable OpenSSL asm runtimes on Windows #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kerby Geffrard <[email protected]>
bernie-laberge
approved these changes
Jul 6, 2023
tbabiin
approved these changes
Jul 6, 2023
tbabiin
pushed a commit
to tbabiin/OpenRV
that referenced
this pull request
Jul 17, 2023
Signed-off-by: Inouk Babin-Ruel <[email protected]> <!-- Thanks for your contribution! Please read this comment in its entirety. It's quite important. When a contributor merges the pull request, the title and the description will be used to build the merge commit! It should be in the following format: [ 12345: Summary of the changes made ] Where 12345 is the corresponding Github Issue OR [ Summary of the changes made ] If it's solving something trivial, like fixing a typo. --> Reverts AcademySoftwareFoundation#150 on Windows. There are reports in the field that there are build failures related to nasm on the OpenSSL build. It seems to work fine in my test environment, but not everywhere. It's safe to disable it on Windows since it was disabled at first. It only got enabled because it was required on MacOS and I wanted to have the same configuration on all 3 platforms. It's a revert. It's the configuration that is being used in the Commercial RV build. attention during the review. N/A N/A Signed-off-by: Kerby Geffrard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
Reverts #150 on Windows.
Describe the reason for the change.
There are reports in the field that there are build failures related to nasm on the OpenSSL build. It seems to work fine in my test environment, but not everywhere. It's safe to disable it on Windows since it was disabled at first. It only got enabled because it was required on MacOS and I wanted to have the same configuration on all 3 platforms.
Describe what you have tested and on which operating system.
It's a revert. It's the configuration that is being used in the Commercial RV build.
Add a list of changes, and note any that might need special attention during the review.
N/A
If possible, provide screenshots.
N/A