Fix windows build/CI with threading disabled #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI was failing to actually set OPENEXR_THREADING_ENABLED for the macOS and Windows builds. And the Windows build as failing with threading disabled, due to a missing header. Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
force-pushed
the
thread-windows-fix
branch
from
fb8aa43 to
58d63b2
Compare
cary-ilm
changed the title
|
This is sort of blocking the other CI change, #1921, so I'm going to go ahead and merge it, I think it should be uncontroversial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI was failing to actually set OPENEXR_THREADING_ENABLED for the
macOS and Windows builds.
And the Windows build as failing with threading disabled, due to a missing header.