Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minor huf encode / decode performance optimizations #1947

Merged

Conversation

kdt3rd
Copy link
Contributor

@kdt3rd kdt3rd commented Dec 31, 2024

uses likely / unlikely macros to better guide branch predictor, convert some static / local functions from functions to macros to avoid having to take the address of a local variable, preventing register optimizations

uses likely / unlikely macros to better guide branch predictor,
convert some static / local functions from functions to macros to avoid
having to take the address of a local variable, preventing register
optimizations

Signed-off-by: Kimball Thurston <[email protected]>
@kdt3rd
Copy link
Contributor Author

kdt3rd commented Dec 31, 2024

This should also remove some regressions from #1915

Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, happy new year!

Signed-off-by: Kimball Thurston <[email protected]>
@kdt3rd kdt3rd merged commit ad85f1a into AcademySoftwareFoundation:main Jan 1, 2025
36 checks passed
@kdt3rd kdt3rd deleted the minor_huf_optimizations branch January 1, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants