Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move xcm config to seperate file #1903

Merged
merged 5 commits into from
Feb 23, 2022
Merged

move xcm config to seperate file #1903

merged 5 commits into from
Feb 23, 2022

Conversation

zqhxuyuan
Copy link
Contributor

@zqhxuyuan zqhxuyuan commented Feb 18, 2022

closes: #1885
move xcm related config to seperate file including:

  • pallet_xcm
  • cumulus_pallet_xcm
  • orml_xtokens
  • module_xcm_interface.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #1903 (3230a41) into master (52f7062) will decrease coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1903      +/-   ##
==========================================
- Coverage   85.56%   85.18%   -0.39%     
==========================================
  Files          80       79       -1     
  Lines       17058    17330     +272     
==========================================
+ Hits        14596    14762     +166     
- Misses       2462     2568     +106     
Impacted Files Coverage Δ
modules/evm/src/runner/state.rs 48.15% <0.00%> (-6.91%) ⬇️
modules/evm/rpc/src/lib.rs 10.63% <0.00%> (-0.38%) ⬇️
primitives/src/unchecked_extrinsic.rs 0.00% <0.00%> (ø)
modules/evm/rpc/runtime_api/src/lib.rs 0.00% <0.00%> (ø)
modules/evm/src/runner/storage_meter.rs 97.08% <0.00%> (ø)
rpc/src/lib.rs
modules/evm/src/tests.rs 99.26% <0.00%> (+0.04%) ⬆️
modules/evm/src/lib.rs 65.03% <0.00%> (+0.92%) ⬆️
modules/evm/src/runner/stack.rs 57.88% <0.00%> (+2.32%) ⬆️
modules/evm/src/precompiles.rs 55.93% <0.00%> (+5.56%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f7062...3230a41. Read the comment docs.

@zqhxuyuan zqhxuyuan marked this pull request as ready for review February 22, 2022 06:53
@zqhxuyuan zqhxuyuan requested review from xlc, shaunxw and zjb0807 February 22, 2022 06:53
xlc
xlc previously approved these changes Feb 22, 2022
shaunxw
shaunxw previously approved these changes Feb 22, 2022
runtime/mandala/src/xcm_config.rs Outdated Show resolved Hide resolved
runtime/karura/src/xcm_config.rs Outdated Show resolved Hide resolved
runtime/acala/src/xcm_config.rs Outdated Show resolved Hide resolved
@zqhxuyuan zqhxuyuan dismissed stale reviews from shaunxw and xlc via 3230a41 February 23, 2022 00:28
@shaunxw shaunxw enabled auto-merge (squash) February 23, 2022 01:16
@shaunxw shaunxw merged commit d42d853 into master Feb 23, 2022
@shaunxw shaunxw deleted the seperate_xcm_config branch February 23, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move XCM configurations out into its own module
3 participants