Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add number input support for event data editing #648

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

BelKed
Copy link
Contributor

@BelKed BelKed commented Mar 1, 2025

Screenshot 2025-03-01 at 01 09 34 Screenshot 2025-03-01 at 01 48 14


Important

Adds number input support in EventEditor.vue for editing numeric event data.

  • Behavior:
    • Adds support for number input in EventEditor.vue by checking if event.data[k] is a number and using b-input with type="number".
  • UI:
    • Enhances the event data editing interface to handle numeric values, allowing users to input numbers directly.

This description was created by Ellipsis for 5f140f2. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 5f140f2 in 56 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. src/components/EventEditor.vue:36
  • Draft comment:
    Consider using v-else-if for mutually exclusive type checks to ensure only one input renders per data key. Also, a fallback for unhandled types might be useful.
  • Reason this comment was not posted:
    Comment was on unchanged code.
2. src/components/EventEditor.vue:36
  • Draft comment:
    Consistency: Consider using the same type-check style for all types. For example, replace 'typeof event.data[k] === "number"' with 'typeof event.data[k] === typeof 1' to match the boolean and string checks.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
3. src/components/EventEditor.vue:36
  • Draft comment:
    v-model.number Note: v-model.number converts empty or invalid inputs to 0. Confirm this behavior is intended or add validation/placeholder as needed.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None

Workflow ID: wflow_e9BP5IYDzkf8YdDU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.76%. Comparing base (1b9d787) to head (5f140f2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   26.76%   26.76%           
=======================================
  Files          28       28           
  Lines        1655     1655           
  Branches      292      288    -4     
=======================================
  Hits          443      443           
  Misses       1155     1155           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ErikBjare ErikBjare merged commit cb9a7ec into ActivityWatch:master Mar 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants