Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api, api_nested examples, update docs #48

Merged
merged 25 commits into from
May 29, 2021
Merged

Update api, api_nested examples, update docs #48

merged 25 commits into from
May 29, 2021

Conversation

mahenzon
Copy link
Collaborator

@mahenzon mahenzon commented May 26, 2021

Freeze Flask < 2, sqlalchemy < 1.4

Code in the examples was really outdated. Updated it to work with flask-combo-jsonapi
Create http snippets via https://github.com/Kong/httpsnippet, render results, add everything in docs (almost automatically). Check it here:
https://flask-combo-jsonapi.readthedocs.io/en/develop/minimal_api_example.html
and here:
https://flask-combo-jsonapi.readthedocs.io/en/develop/quickstart.html

Update docs' grammar

@coveralls
Copy link

coveralls commented May 26, 2021

Pull Request Test Coverage Report for Build 885128859

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 82.894%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flask_combo_jsonapi/data_layers/alchemy.py 3 5 60.0%
Totals Coverage Status
Change from base Build 877196384: -0.07%
Covered Lines: 1289
Relevant Lines: 1555

💛 - Coveralls

@mahenzon mahenzon requested review from Znbiz and dmitrymishanov May 27, 2021 11:23
mahenzon and others added 10 commits May 27, 2021 14:37
…and more

Fix grammar
Fix typo
Fix grammar and phrasing
Fix ortography
Fix grammar, phrasing
Fix conjugations and grammar
Fix conjugations, grammar, sqlalchemy -> SQLAlchemy
Fix conjugations, grammar, JSONAPI -> JSON:API
Revised grammar
Update docs: fix grammar, typos, phrasing, orthography, conjugations
@mahenzon
Copy link
Collaborator Author

mahenzon commented May 28, 2021

@Znbiz @dmitrymishanov please someone take a look. No real code was changed. Only requirements freeze, examples upgrades and docs updates. Let's release it

@mahenzon mahenzon removed the request for review from dmitrymishanov May 29, 2021 11:38
@Znbiz Znbiz merged commit bb8472b into master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants