Fix horizontal scrolling #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update react-data-grid to version v5x
jcshott
commented
Jul 27, 2022
| @@ -8,17 +8,13 @@ export default class RowRenderer extends React.Component { | |||
| idx: PropTypes.number.isRequired | |||
| }; | |||
|
|
|||
| setScrollLeft = (scrollBy) => { | |||
There was a problem hiding this comment.
this didn't appear to be used and was just confusing.
|
Would you be able to link to the react-data-grid PR that fixes horizontal scrolling or a note in the version history on this, if you have it handy? |
|
I'll see if I can find it - after a lot of searching (v4 didn't have a lot of info), I just tried updating to see if it worked - figuring a 4 -> 5 would minimize other potential issues (since we don't really use a lot of features) and it seemed to fix it. so I just ran with it :) but I might be able to figure out what was fixed and link here. Edit: I believe it's version 5.0.2 that fixes horizontal scrolling there were a couple updates that addressed issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update react-data-grid to version v5x (which appears to fix no horizontal scrolling)
there are deprecation warnings that show up and this solves it: adazzle/react-data-grid#1403 (comment)
I didn't want to upgrade all the way to v7x (which fixed the warnings) as it doesn't seem stable and could open a pandora's box of problems. one version upgrade seems to be ok.