Add rebar3 formatting #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanbono
reviewed
Apr 15, 2020
| TargetAPI :: string() | undefined, % e.g., "DynamoDB_20120810.CreateTable" | ||
| Method :: string(), % e.g., "GET", "POST" | ||
| Path :: string(), | ||
| Service :: string(), |
There was a problem hiding this comment.
…by hand, yes… I could've just moved them but I thought they pretty much stated the obvious.
raz-adroll
reviewed
Apr 15, 2020
| [Credentials] -> | ||
| MinLifetime = ?MIN_LIFETIME, | ||
| case remaining_lifetime(Credentials) of | ||
| N when N =< MinLifetime -> |
There was a problem hiding this comment.
case indentation is 2 and the statement body is actually 4, is that expected?
There was a problem hiding this comment.
Well, it seems that that's the case for all cases, so, I guess it's expected
There was a problem hiding this comment.
It's expected and configurable: it's called sub_indent, the default is 2 but we can use 4 to match the rest of the indentation.
There was a problem hiding this comment.
We should be consistent across projects, tho… and we're using the default for spillway, mero, etc…
raz-adroll
reviewed
Apr 15, 2020
juanbono
approved these changes
Apr 15, 2020
raz-adroll
reviewed
Apr 15, 2020
raz-adroll
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.