Implement pypi simulator + e3-pypi-closure yanked tests #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leocardao
force-pushed
the
mr/cardao/pypi-simulator
branch
from
5bc154a to
865e620
Compare
leocardao
changed the title
leocardao
force-pushed
the
mr/cardao/pypi-simulator
branch
2 times, most recently
from
d686c19 to
395cc65
Compare
grouigrokon
reviewed
Jan 25, 2024
grouigrokon
reviewed
Jan 25, 2024
grouigrokon
reviewed
Jan 25, 2024
grouigrokon
reviewed
Jan 25, 2024
grouigrokon
reviewed
Jan 25, 2024
grouigrokon
reviewed
Jan 25, 2024
leocardao
force-pushed
the
mr/cardao/pypi-simulator
branch
from
395cc65 to
dedd9af
Compare
|
I solved all the comments about exceptions because I changed the way errors are handled in PypiSimulator. As I said, requests-mock catches errors and turns them into "Internal server error". So I've improved error handling by separating the code from Pypi's behavior and adding a whole bunch of information. |
leocardao
force-pushed
the
mr/cardao/pypi-simulator
branch
from
dedd9af to
4207abe
Compare
grouigrokon
reviewed
Jan 25, 2024
grouigrokon
reviewed
Jan 25, 2024
leocardao
force-pushed
the
mr/cardao/pypi-simulator
branch
from
4207abe to
0670233
Compare
grouigrokon
previously approved these changes
Jan 25, 2024
leocardao
force-pushed
the
mr/cardao/pypi-simulator
branch
from
0670233 to
18247cd
Compare
grouigrokon
reviewed
Jan 25, 2024
The pypi simulator is used to simulate the interactions between our code and the real pypi. Addresses are mocked, and for the moment it only simulates requests in https://pypi.org/pypi/<YOUR PACKAGE>/json format. Test json metadata must be downloaded in advance and placed in tests/tests_e3/pypi_data/json. Related to AdaCore#671
Related to AdaCore#671
leocardao
force-pushed
the
mr/cardao/pypi-simulator
branch
from
18247cd to
62ba3bf
Compare
grouigrokon
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pypi simulator is used to simulate the interactions between our code and the real pypi.
Addresses are mocked, and for the moment it only simulates requests in https://pypi.org/pypi//json format.
Test json metadata must be downloaded in advance and placed in tests/tests_e3/pypi_data/json.
This PR also add e3-pypi-closure yanked tests.
Related to #671