This repository has been archived by the owner on Apr 5, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package relies on alias behavior from pre 1.6 Ember..
emberjs/ember.js#9265 (comment)
This replicates the old behavior by implementing
alias
as acomputed
. In the main application where ember-charts is used this is already being done, and this package on the whole may not even work without this change.In order to get the codemod I wrote to fix the
alias
I needed to first run https://github.com/ember-codemods/ember-modules-codemod which converted the global use to the module import use