Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

Update alias to use legacyAlias #251

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rondale-sc
Copy link
Contributor

This package relies on alias behavior from pre 1.6 Ember..

emberjs/ember.js#9265 (comment)

This replicates the old behavior by implementing alias as a computed. In the main application where ember-charts is used this is already being done, and this package on the whole may not even work without this change.

In order to get the codemod I wrote to fix the alias I needed to first run https://github.com/ember-codemods/ember-modules-codemod which converted the global use to the module import use

@rondale-sc rondale-sc requested a review from mixonic April 11, 2021 15:21
@rondale-sc
Copy link
Contributor Author

@mixonic We're not the only consumers of this (presumably) which may mean that the legacyAlias will behave differently for those consumers. However, I'm fairly certain that this addon doesn't work at all without this change (to legacyAlias).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant