Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP server improvements #2343

Closed
ainar-g opened this issue Nov 20, 2020 · 0 comments
Closed

HTTP server improvements #2343

ainar-g opened this issue Nov 20, 2020 · 0 comments
Assignees
@EugeneOne1
Labels
enhancement P3: Medium
Milestone
v0.105.0

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Nov 20, 2020

Two important HTTP server improvements:

  1. We shouldn't use http.DefaultServeMux at all.

  2. We should set timeouts on our HTTP servers. For now, a constant of, say, 10 seconds should be enough.
@ainar-g ainar-g added this to the v0.105 milestone Nov 20, 2020
adguard pushed a commit that referenced this issue Dec 10, 2020
@EugeneOne1 @Blakhard
Pull request: 2343 http server
5210a34 
Merge in DNS/adguard-home from 2343-http-server to master

Closes #2343.

Squashed commit of the following:

commit f4ebfc1
Merge: b13ec70 36c7735
Author: Eugene Burkov <[email protected]>
Date:   Wed Nov 25 15:37:27 2020 +0300

    Merge branch 'master' into 2343-http-server

commit b13ec70
Author: Eugene Burkov <[email protected]>
Date:   Wed Nov 25 15:31:36 2020 +0300

    all: record changes

commit ce44aac
Author: Eugene Burkov <[email protected]>
Date:   Wed Nov 25 14:00:45 2020 +0300

    home: set http servers timeouts

commit 7f3e738
Author: Eugene Burkov <[email protected]>
Date:   Tue Nov 24 19:58:56 2020 +0300

    home: replace default ServeMux with custom one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
enhancement P3: Medium
Projects
None yet
Milestone
v0.105.0
Development

No branches or pull requests
2 participants
@ainar-g @EugeneOne1