Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The query log does not display the data correctly. #2345

Closed
hezhijie0327 opened this issue Nov 21, 2020 · 5 comments
Closed

The query log does not display the data correctly. #2345

hezhijie0327 opened this issue Nov 21, 2020 · 5 comments
Assignees
@EugeneOne1
Labels
bug P3: Medium
Milestone
v0.105.0

Comments

@hezhijie0327
Copy link

hezhijie0327 commented Nov 21, 2020 •
edited
Loading

Version: v0.104.3-046ec13f

The blocked domain name is not marked in red and the filter name is not displayed
The domain name that was not blocked does not display the upstream DNS server name, and all elapsed time is 0.00ms (even if DNS cache is turned off).

Xnip 2020-11-21 08 24 20

Xnip 2020-11-21 08 29 49

Xnip 2020-11-21 08 25 14
@ameshkov ameshkov added this to the v0.105 milestone Nov 23, 2020
@ameshkov
Copy link
Member

Weird, I cannot reproduce this.

@hezhijie0327
Copy link
Author

Well, I found out why this happened. The "querylog_size_memory: 0" in the settings is the cause of the problem. But what puzzles me is that the value of 0 did not cause this problem in previous versions. And now after I set it to 1000, the previous log still shows 0ms.
Xnip 2020-11-23 23 02 45
Xnip 2020-11-23 23 06 06

@hezhijie0327
Copy link
Author

0 < querylog_size_memory <= 5: The same issue like 0.
querylog_size_memory > 5: It becomes normal.

@ameshkov
Copy link
Member

Thank you! Definitely a bug.

@ainar-g
Copy link
Contributor

ainar-g commented Nov 27, 2020

Should be fixed as of snapshot 60d72fb. Please feel free to reopen with more details if it isn't!

adguard pushed a commit that referenced this issue Dec 10, 2020
@EugeneOne1 @Blakhard
Pull request: fix querylog bug
991c934 
Merge in DNS/adguard-home from 2345-querylog-bug-fix to master

Closes #2345.

Squashed commit of the following:

commit 3ebd13e
Author: Eugene Burkov <[email protected]>
Date:   Fri Nov 27 12:14:49 2020 +0300

    all: make changelog more humanly readable.

commit 3c9bb1b
Author: Eugene Burkov <[email protected]>
Date:   Thu Nov 26 14:43:14 2020 +0300

    all: log changes

commit 08c67da
Merge: 650d224 96e83a1
Author: Eugene Burkov <[email protected]>
Date:   Thu Nov 26 14:42:18 2020 +0300

    Merge branch 'master' into 2345-querylog-bug-fix

commit 650d224
Author: Eugene Burkov <[email protected]>
Date:   Thu Nov 26 14:02:57 2020 +0300

    querylog: fix json parsing bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.105.0
Development

No branches or pull requests
4 participants
@ainar-g @ameshkov @EugeneOne1 @hezhijie0327