-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the mobileconfig API parameterized and more robust #2358
Comments
Since it now uses the hostname provided by the client, it does not matter how it was requested.
Yep, if the hostname parameter is empty, we can use
If |
Merge in DNS/adguard-home from 2358-mobileconfig to master Updates #2358. Squashed commit of the following: commit ab3c7a7 Merge: fa002e4 b4a35fa Author: Ainar Garipov <[email protected]> Date: Wed Nov 25 16:11:06 2020 +0300 Merge branch 'master' into 2358-mobileconfig commit fa002e4 Author: Ainar Garipov <[email protected]> Date: Wed Nov 25 15:19:00 2020 +0300 home: improve mobileconfig http api
The backend and the documentation are mostly done. @ArtemBaskal, could you please add the frontend logic? |
…and more robust Merge in DNS/adguard-home from feature/2358 to master Updates #2358. Squashed commit of the following: commit b2b91ee Author: Artem Baskal <[email protected]> Date: Tue Dec 1 14:54:35 2020 +0300 + client: 2358 Make the mobileconfig API parameterized and more robust
I feel like this is done for now. @ameshkov, should we keep this issue open for future improvements, for example multiple hosts support, or should we close this issue for now? |
@ainar-g nope, let's close it |
Merge in DNS/adguard-home from 2358-mobileconfig to master Updates #2358. Squashed commit of the following: commit ab3c7a7 Merge: fa002e4 b4a35fa Author: Ainar Garipov <[email protected]> Date: Wed Nov 25 16:11:06 2020 +0300 Merge branch 'master' into 2358-mobileconfig commit fa002e4 Author: Ainar Garipov <[email protected]> Date: Wed Nov 25 15:19:00 2020 +0300 home: improve mobileconfig http api
…and more robust Merge in DNS/adguard-home from feature/2358 to master Updates #2358. Squashed commit of the following: commit b2b91ee Author: Artem Baskal <[email protected]> Date: Tue Dec 1 14:54:35 2020 +0300 + client: 2358 Make the mobileconfig API parameterized and more robust
We've already had quite a few bugs about the mobileconfig HTTP API and its autoselection of hostnames. Instead of churning out more temporary solutions, let's solve the issue in a more systematic way in v0.105.0:
(Updated 2020-11-27 after @ameshkov's comments.)
The mobileconfig API MUST NOT respond with naked IP addresses or hosts with ports.tls.server_name
, and if it's not set, return a 500 error.tls.server_name
is set. Perhaps show a form for getting a link with the desired host instead.Things to think about and figure out:
tls.server_name
parameter required? What about servers that can accept connections targeting multiple hosts?A: It is required, but only when clients don't provide a host of their own.
A: The default is
tls.server_name
.A: No, since clients provide the host now.
A: If
tls.server_name
is set, it does not matter what certificate is used. If not, handle this in the UI and ask users to enter the required hostname.@ameshkov, can you please validate my thoughts here?
The text was updated successfully, but these errors were encountered: