AdGuardHome installed wrong Init script

[berna1995]

• Version of AdGuard Home server:
  • 0.105.1
• How did you install AdGuard Home:
  • Github release, manually
• How did you setup DNS configuration:
  • Router
• If it's a router or IoT, please write device model:
  • DGA4130
• CPU architecture:
  • ARM
• Operating system and version:
  • OpenWRT 15.05

Expected Behavior

After install, i would exepct AdGuard to run and enable the correct init script

Actual Behavior

Init script is installed in /etc/init.d but it's not the correct one for OpenWRT and so it doesn't "enable" it.

Additional Information

Problem might be related to how OpenWRT is detected.

AdGuardHome/internal/util/helpers.go

Lines 68 to 79 in 0d67aa2

	func IsOpenWRT() bool {
	if runtime.GOOS != "linux" {
	return false
	}
	body, err := ioutil.ReadFile("/etc/os-release")
	if err != nil {
	return false
	}
	return strings.Contains(string(body), "OpenWrt")
	}

There is no guarantee that /etc/os-release file will be present in the host system, you should rather look for /etc/openwrt_release.

[EugeneOne1]

We've tried to improve the OpenWRT detection as of snapshot 91403d0. Could you please check if our solution fixes the issue for you?

[berna1995]

I unfortunately cannot, at the moment, im running AdGuard Home in my main router and i would love not to reinstall it from scratch.

[EugeneOne1]

Well, thanks for opening an issue anyway. Our testers checked the solution on our test machines, including the OpenWRT one, before it was merged to master. The closest update which will include that commit is 0.105.2. We'll close the issue for now. Feel free to reopen it if the bug persists after updating.

[adworacz]

I just ran into this bug using a custom build from Divested, which is effectively running OpenWRT HEAD with a few patches.

Looking at the AdguardHome code, it's checking for "OpenWrt" in /etc/*release.

However /etc/openwrt_release DOES exist, and contains the following:

DISTRIB_ID='Divested-WRT'
DISTRIB_RELEASE='SNAPSHOT'
DISTRIB_REVISION='r17276+9-b1bff5cb57'
DISTRIB_TARGET='mvebu/cortexa9'
DISTRIB_ARCH='arm_cortex-a9_vfpv3-d16'
DISTRIB_DESCRIPTION='Divested-WRT SNAPSHOT r17276+9-b1bff5cb57'
DISTRIB_TAINTS='no-all'

Edit: Actually /etc/os-release exists as well, and contains:

NAME="Divested-WRT"
VERSION="SNAPSHOT"
ID="divested-wrt"
ID_LIKE="lede openwrt"
PRETTY_NAME="Divested-WRT SNAPSHOT"
VERSION_ID="snapshot"
HOME_URL="https://divested.dev/unofficial-openwrt-builds/mvebu-linksys"
BUG_URL="https://github.com/divestedcg/Divested-WRT/issues"
SUPPORT_URL="xmpp:[email protected]?join"
BUILD_ID="r17276+9-b1bff5cb57"
OPENWRT_BOARD="mvebu/cortexa9"
OPENWRT_ARCH="arm_cortex-a9_vfpv3-d16"
OPENWRT_TAINTS="no-all"
OPENWRT_DEVICE_MANUFACTURER="Divested Computing Group"
OPENWRT_DEVICE_MANUFACTURER_URL="https://divested.dev"
OPENWRT_DEVICE_PRODUCT="Generic"
OPENWRT_DEVICE_REVISION="v0"
OPENWRT_RELEASE="Divested-WRT SNAPSHOT r17276+9-b1bff5cb57"