-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DHCP offer ignored for some clients. #4337
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@zglurb Apologies for the long silence! |
Yes, I still have this issue with v0.107.9. |
Merge in DNS/adguard-home from 4337-dhcp-cli-id to master Updates #4337. Squashed commit of the following: commit c393bf7 Author: Eugene Burkov <[email protected]> Date: Fri Aug 26 14:18:48 2022 +0300 dhcpd: ip docs commit bfeef3e Author: Eugene Burkov <[email protected]> Date: Fri Aug 26 13:54:33 2022 +0300 all: finish chlog fmt commit e5fbb73 Author: Eugene Burkov <[email protected]> Date: Fri Aug 26 13:49:10 2022 +0300 dhcpd: imp naming commit cb49eeb Author: Eugene Burkov <[email protected]> Date: Fri Aug 26 12:23:54 2022 +0300 dhcpd: imp docs commit c4ea72a Author: Eugene Burkov <[email protected]> Date: Thu Aug 25 20:15:15 2022 +0300 dhcpd: imp code, docs commit 36d0e30 Author: Eugene Burkov <[email protected]> Date: Thu Aug 25 19:45:24 2022 +0300 dhcpd: add del opt
@zglurb, hello again. This is actually an insteresting case. Could you please provide some details about the aforementioned device? Is it somehow old? FYI, the RFC 6842 states that the option must be present if client sends it. We've actually implemented the |
The device is a Devmel AirSend (http://devmel.com/en/airsend.html). I use it to control my shutters. It's not old. I bought mine 2 years ago. I don't know what kind of board it's using or what OS it's running on. Anyway, I'll try the last edge build with the |
OK so I updated my docker image to Here are more details (copy and paste from Wireshark) if you want to take a look at it. Otherwise it's OK, I'm fine with my router DHCP server. DHCP discovery request from my device.
Ignored DHCP offer from AdGuard Home
Accepted DHCP offer by my router
I censored the MAC addresses. |
@zglurb, I can't seem any significant discrepancies between the frames either. Could you please try to make those closer by setting the option |
@EugeneOne1, just to be clear, the duplicated IP address is sent by AdGuard Home to prevent OSs, especially Android, from using one of their default servers as a secondary server. It would be weird if this is the thing that makes this particular device reject the lease, although not impossible, of course. |
@zglurb, we've came up with a few more suggestions. Could you please try to perform the following? Firstly, check for updates of the Devmel AirSend's firmware? The outdated firmware versions often may cause such issues on IoT devices. Then check for some cached DHCP configurations and leases from the router's DHCP. Perhaps, there is some kind of reset button to clear those. Afterwards, try to create a static lease for the device with the If any of suggested helped? If no, could you please send us the whole Wireshark's dump file to inspect it thoroughly? You may send it to [email protected]. |
@zglurb, is the issue still relevant? |
Sorry I didn't have time to run these tests before. Yes I still have the issue.
They don't seem to provide any way to update the firmware.
Do you mean some kind of security to only accept DHCP offers from a specific server ? I didn't find a way to reset the device. Neither a physical button nor an option in the app.
I tried both, didn't change anything.
I'm sending you an email with 2 non filtered Wireshark exports. One with AdGuard as DHCP server, the other one with my router. |
@zglurb, we've received and are investigating the files. Thanks for you help. |
Merge in DNS/adguard-home from 4337-dhcp-msg-len to master Updates #4337. Squashed commit of the following: commit 55e53c1 Merge: f37070e da1ae33 Author: Eugene Burkov <[email protected]> Date: Wed Sep 7 14:14:21 2022 +0300 Merge branch 'master' into 4337-dhcp-msg-len commit f37070e Author: Eugene Burkov <[email protected]> Date: Wed Sep 7 13:15:25 2022 +0300 dhcpd: imp ether pkt building commit fa43a0b Author: Eugene Burkov <[email protected]> Date: Tue Sep 6 18:55:07 2022 +0300 dhcpd: incr msg size
@zglurb, hello again. We've checked the dumps and indeed there is no much difference between the DHCP responses. However, the thing that caught our attention is the amount of padding in the router's response. This led us to the RFC 2131 and the obsolete version of it (RFC 1541) which are recommending to keep the minimum size of the message of 576 bytes (perhaps, some clients refuse the smaller messages). So we've implemented it in the latest edge build. Could you please check it out? |
Hello again, Sorry, still no success. The packets did get bigger after the update (342 bytes before, 618 after) but they are still ignored. I have created a ticket to Devmel to ask them if it's possible to access the device to view the logs. I've also sent them the link to this issue. I'll get back to you if I get a positive answer. |
I am having this issue as well but it only affects Roku devices, wired and wireless, after updating to v0.107.12. AGH is running on Ubuntu server using the install script from here (not Docker). Packet captures show the DHCP Discover and DHCP Offer but the Roku does not accept the DHCP IP. This is the first time I've had this issue. I tried to add a static DHCP mapping but that didn't work. I thought it might be because the Roku was sending option 12 (Host Name) but when I tried to add a static for the MAC, IP, and host name of RokuDevice, I received an error that the hostname is not unique. Is there a log or a capture I can provide to help with troubleshooting? Edit: I tried on a different SSID that uses a different DHCP server. That was successful on the Roku devices. The failing DHCP offers from AGH have a length of 782. I did notice in the AGH DHCP Offer there is a padding at the end of the bootstrap versus the other DHCP server ACK doesn't have padding. |
@zglurb, there were some newer fixes in v0.107.13. Does the issue still persist? @brad925, have you tried the latest version? Regarding the logs, see the verbose logs section in our FAQ. |
So I had a problem similar to @brad925. I've been fighting connectivity issues for 2 days now. We have 20+ devices on our home network between air conditioners, laptops, phones, thermostats, smart plugs, etc. Every single one is working fine, and has been for months. That is until 2 days ago when the Blink video doorbells stopped working right. No live view, no motion alerts, no video capture. Removed from app, unable to re-add them. Thought it was their flaky wifi hardware until the Roku TVs started dropping too. Main living room one, hard wired, was fine until tonight when it too failed to get an IP address wireless or hardwired. Finally on a whim I decided to try switching DHCP servers after reading this thread. (Didn't think it would help since I've released/renewed IPs and dropped/connected to WiFi a hundred times in the last 2 days chasing this issue.) -Turned off AGH (completely, shut down the container on my NAS) and enabled the DHCP server on my router. Roku reconnected. WTF. Edit: Well at least Blink finally emailed me saying login issues have been resolved, even though I never saw a notification there was an official issue in the first place. So that is explained now. |
@ainar-g Yes, I still have this issue. I've also got an answer from the device manufacturer. They told me that they know about the incompatibility issues with some DHCP servers. They haven't localised the problem yet and it's not a priority for them. |
Merge in DNS/adguard-home from 4337-dhcp-cli-id to master Updates AdguardTeam#4337. Squashed commit of the following: commit c393bf7 Author: Eugene Burkov <[email protected]> Date: Fri Aug 26 14:18:48 2022 +0300 dhcpd: ip docs commit bfeef3e Author: Eugene Burkov <[email protected]> Date: Fri Aug 26 13:54:33 2022 +0300 all: finish chlog fmt commit e5fbb73 Author: Eugene Burkov <[email protected]> Date: Fri Aug 26 13:49:10 2022 +0300 dhcpd: imp naming commit cb49eeb Author: Eugene Burkov <[email protected]> Date: Fri Aug 26 12:23:54 2022 +0300 dhcpd: imp docs commit c4ea72a Author: Eugene Burkov <[email protected]> Date: Thu Aug 25 20:15:15 2022 +0300 dhcpd: imp code, docs commit 36d0e30 Author: Eugene Burkov <[email protected]> Date: Thu Aug 25 19:45:24 2022 +0300 dhcpd: add del opt
Merge in DNS/adguard-home from 4337-dhcp-msg-len to master Updates AdguardTeam#4337. Squashed commit of the following: commit 55e53c1 Merge: f37070e da1ae33 Author: Eugene Burkov <[email protected]> Date: Wed Sep 7 14:14:21 2022 +0300 Merge branch 'master' into 4337-dhcp-msg-len commit f37070e Author: Eugene Burkov <[email protected]> Date: Wed Sep 7 13:15:25 2022 +0300 dhcpd: imp ether pkt building commit fa43a0b Author: Eugene Burkov <[email protected]> Date: Tue Sep 6 18:55:07 2022 +0300 dhcpd: incr msg size
I confirm. my pc wifi lan card dont get dhcp leases |
Hi there!, I'm now experimenting this same issue ! |
Issue Details
Expected Behavior
I've just installed AdGuard Home and enabled the DHCP server after disabling the one from my router.
I expect my devices to get their network configuration from the AdGuard's DHCP server.
Actual Behavior
It's working fine for all of my devices except for one that ignores DHCP offers.
In an old issue, I've read this :
I don't really have access to my device. It's an IoT device, not a computer or a phone so i can't check that. But i figured it might be the issue.
Using Wireshark I compared the DHCP offers from my router (which is accepted) and from AdGuard (which is ignored) and the only difference I could spot was this option in AdGuard's offer that was not in my routers.
Is there an option to prevent AdGuard Home sending this so I can test if this is really the cause of the issue?
The text was updated successfully, but these errors were encountered: