Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom filtering rules dissappeared, #4945

Closed
3 tasks done
RonKhondji opened this issue Sep 23, 2022 · 7 comments
Closed
3 tasks done

Custom filtering rules dissappeared, #4945

RonKhondji opened this issue Sep 23, 2022 · 7 comments
Assignees
Milestone

Comments

@RonKhondji
Copy link

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Linux, OpenWrt

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

Built from 'Master'

Description

Commit "Pull request: 4871 imp filtering" {47c9c94} has deleted all my custom filtering rules from AdGuardHome.yaml.

The relevant line has reverted to "user_rules: []".

I had a backup of most of them so it was easy enough to put them back, but it looks like an unintended effect of the filtering improvements.

@ghost
Copy link

ghost commented Sep 23, 2022

Same happened here (latest ARM64 Edge release on Raspberry Pi 4). I also wasn't able to save rules once I pasted them from earlier YAML file. I had to revert to previous release to get everything back up and running.

@Dynasty-Dev
Copy link

Having the same issue here on the latest edge build

@tmiland
Copy link

tmiland commented Sep 25, 2022

Same issue.

@ghost
Copy link

ghost commented Sep 29, 2022

Has this been fixed?

@EugeneOne1 EugeneOne1 self-assigned this Sep 29, 2022
@EugeneOne1 EugeneOne1 added the needs investigation Needs to be reproduced reliably. label Sep 29, 2022
@EugeneOne1 EugeneOne1 added this to the v0.107.15 milestone Sep 29, 2022
@EugeneOne1 EugeneOne1 added bug P2: High and removed needs investigation Needs to be reproduced reliably. labels Sep 29, 2022
@ainar-g ainar-g modified the milestones: v0.107.15, v0.107.14 Sep 29, 2022
adguard pushed a commit that referenced this issue Sep 29, 2022
Merge in DNS/adguard-home from 4945-fix-user-rules to master

Updates #4945.
Updates #4871.

Squashed commit of the following:

commit 415a262
Author: Eugene Burkov <[email protected]>
Date:   Thu Sep 29 18:05:48 2022 +0300

    home: fix user rules
@EugeneOne1
Copy link
Member

@RonKhondji, hello and thanks for the report. Indeed we've introduced a bug in the recent update. Should be fixed in the latest edge build. Could you please check it out?

@7ArxS2PrqAUF9Gom, @Dynasty-Dev, @tmiland, could you also please give a feedback on the issue status?

@RonKhondji
Copy link
Author

New build did not delete custom rules. All good again.

@EugeneOne1
Copy link
Member

@RonKhondji, great to hear. Thanks for testing, we're closing the issue now. Please, feel free to open new issues on found problems.

adguard pushed a commit that referenced this issue Oct 3, 2022
Merge in DNS/adguard-home from 4983-fix-custom-svcs to master

Updates #4945.
Updates #4982.

* commit '739e0098ec127045197ea697bae78acb2bd2c729':
  all: imp code, wording
  home: fix empty svcs
  bugfix: Fixed bug which was causing clients to continue following global service blocks even when user opted to not do that
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 4945-fix-user-rules to master

Updates AdguardTeam#4945.
Updates AdguardTeam#4871.

Squashed commit of the following:

commit 415a262
Author: Eugene Burkov <[email protected]>
Date:   Thu Sep 29 18:05:48 2022 +0300

    home: fix user rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants