Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new --update flag does not work #5191

Closed
3 tasks done
siavashs opened this issue Nov 25, 2022 · 2 comments
Closed
3 tasks done

The new --update flag does not work #5191

siavashs opened this issue Nov 25, 2022 · 2 comments
Assignees
Milestone

Comments

@siavashs
Copy link

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Linux, Other (please mention the version in the description)

CPU architecture

32-bit MIPS LE

Installation

GitHub releases or script from README

Setup

On a router, DHCP is handled by the router

AdGuard Home version

v0.107.19

Description

What did you do?

Ran ./AdGuardHome --update on EdgeRouter X

Expected result

AdGuardHome to check for updates and exit as it's already running the latest version.

Actual result

It printed a DHCP error and just waited:

# ./AdGuardHome --update
2022/11/25 11:58:06.612383 [info] AdGuard Home, version v0.107.19
2022/11/25 11:58:06.675757 [info] tls: using default ciphers
2022/11/25 11:58:06.690595 [error] creating dhcpv4 srv: dhcpv4: invalid IP is not an IPv4 address
2022/11/25 11:58:06.722682 [info] Initializing auth module: /config/AdGuardHome/data/sessions.db
^C
2022/11/25 11:58:47.843287 [info] Received signal "interrupt"
2022/11/25 11:58:47.843436 [info] stopping AdGuard Home
2022/11/25 11:58:47.844284 [info] stopped

Screenshots (if applicable)

Additional information

@ainar-g ainar-g added this to the v0.107.20 milestone Nov 25, 2022
adguard pushed a commit that referenced this issue Nov 25, 2022
Merge in DNS/adguard-home from 4944-dhcp-creation to master

Updates #4944.
Updates #5191.

Squashed commit of the following:

commit f5bc567
Author: Eugene Burkov <[email protected]>
Date:   Fri Nov 25 18:07:35 2022 +0300

    all: log changes, imp log

commit 526fe71
Author: Eugene Burkov <[email protected]>
Date:   Fri Nov 25 17:38:30 2022 +0300

    dhcpd: log creation err as debug
@EugeneOne1 EugeneOne1 assigned EugeneOne1 and unassigned Mizzick Dec 27, 2022
adguard pushed a commit that referenced this issue Jan 9, 2023
Merge in DNS/adguard-home from 5191-update-flag to master

Updates #5191.
Updates #4223.

Squashed commit of the following:

commit fbace49
Author: Eugene Burkov <[email protected]>
Date:   Mon Jan 9 12:05:16 2023 +0400

    all: imp code, docs

commit 8237dce
Merge: ca9518f bbdcc67
Author: Eugene Burkov <[email protected]>
Date:   Fri Dec 30 14:45:55 2022 +0400

    Merge branch 'master' into 5191-update-flag

commit ca9518f
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 29 20:36:33 2022 +0400

    home: imp code

commit 1dc6c7c
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 29 18:26:08 2022 +0400

    all: imp code, docs

commit 7bbe893
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 29 03:44:48 2022 +0400

    home: restart service on update

commit e0d3c28
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 29 03:22:49 2022 +0400

    all: update on first run

commit 0aa4e78
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 29 02:47:30 2022 +0400

    all: move some code to init less

commit 68aebfa
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 29 00:36:00 2022 +0400

    WIP

commit 2c7fb97
Author: Eugene Burkov <[email protected]>
Date:   Wed Dec 28 14:15:59 2022 +0400

    home: imp logs

commit 4b06d08
Author: Eugene Burkov <[email protected]>
Date:   Tue Dec 27 19:21:17 2022 +0400

    all: fix update flag
@EugeneOne1
Copy link
Member

EugeneOne1 commented Jan 9, 2023

@siavashs, hello and apologies for the late response. The latest edge release should fix the behavior of the --update flag to make it update the binary and restart the service if the one installed. Note that in order to update the edge release, the next edge release should be published first. You may also want to wait for the following beta build or even the release one.

@EugeneOne1
Copy link
Member

@siavashs, hello again. It works on our machines so far, so I'll close the issue for now if you don't mind. You're welcome to reopen it on issues with the fix.

@ainar-g ainar-g modified the milestones: v0.107.23, v0.107.22 Jan 19, 2023
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 4944-dhcp-creation to master

Updates AdguardTeam#4944.
Updates AdguardTeam#5191.

Squashed commit of the following:

commit f5bc567
Author: Eugene Burkov <[email protected]>
Date:   Fri Nov 25 18:07:35 2022 +0300

    all: log changes, imp log

commit 526fe71
Author: Eugene Burkov <[email protected]>
Date:   Fri Nov 25 17:38:30 2022 +0300

    dhcpd: log creation err as debug
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Merge in DNS/adguard-home from 5191-update-flag to master

Updates AdguardTeam#5191.
Updates AdguardTeam#4223.

Squashed commit of the following:

commit fbace49
Author: Eugene Burkov <[email protected]>
Date:   Mon Jan 9 12:05:16 2023 +0400

    all: imp code, docs

commit 8237dce
Merge: ca9518f bbdcc67
Author: Eugene Burkov <[email protected]>
Date:   Fri Dec 30 14:45:55 2022 +0400

    Merge branch 'master' into 5191-update-flag

commit ca9518f
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 29 20:36:33 2022 +0400

    home: imp code

commit 1dc6c7c
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 29 18:26:08 2022 +0400

    all: imp code, docs

commit 7bbe893
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 29 03:44:48 2022 +0400

    home: restart service on update

commit e0d3c28
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 29 03:22:49 2022 +0400

    all: update on first run

commit 0aa4e78
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 29 02:47:30 2022 +0400

    all: move some code to init less

commit 68aebfa
Author: Eugene Burkov <[email protected]>
Date:   Thu Dec 29 00:36:00 2022 +0400

    WIP

commit 2c7fb97
Author: Eugene Burkov <[email protected]>
Date:   Wed Dec 28 14:15:59 2022 +0400

    home: imp logs

commit 4b06d08
Author: Eugene Burkov <[email protected]>
Date:   Tue Dec 27 19:21:17 2022 +0400

    all: fix update flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants