Support customizing session cookie name. #7072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ainar-g , could you please have a look at this PR |
|
Good day. As recommended in the contribution guidelines, it's better to discuss a change before contributing any code. Currently, we think that it's the job of the reverse proxy (i.e. Nginx) to handle header mutations for unusual configurations, so we'd rather not add complexity for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What scenarios require custom session cookie names?
When multiple AdGuard Home instances are running on a host, having the same IP or domain name, only the port is different, you cannot log in to the web UI of two instances at the same time, because they use the same session cookie name. . After logging into instance A, logging in to instance B will cause the login status on instance A to be invalid.
#4680 and #1196 also mentioned this problem.