Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vivaldi Snapshot and Vivaldi Sopranos to the list of supported browsers #3400

Closed
contribucious opened this issue Apr 2, 2020 · 6 comments
Assignees
Milestone

Comments

@contribucious
Copy link

contribucious commented Apr 2, 2020

Vivaldi browser snapshot version was released on the Play Store on September 20, 2019.
Please add it to the list of supported browsers.

Package name: com.vivaldi.browser.snapshot

Thanks in advance!


Related: #3061 (beta version, not the same)
My AG version used: 3.3.2 (230) [stable] (but Nightly changelog checked before posting.)

@contribucious
Copy link
Author

contribucious commented Apr 3, 2020

Consider adding com.vivaldi.browser.sopranos too:

Note that there now exist three different versions of Vivaldi Android: Beta, Snapshot and Soprano's. The latter being pre-snapshot build for translators and Vivaldi team members.
Each of these three versions has its own android app ID.

Source: A Vivaldi translator

Our testing process is pretty straightforward. When we finish a new feature, we first test it internally (with the help of a small group of Vivaldi volunteers called the Sopranos), then we release the new feature in a Snapshot.

Source: Vivaldi

@contribucious contribucious changed the title Add Vivaldi Snapshot to the list of supported browsers Add Vivaldi Snapshot & Sopranos to the list of supported browsers Apr 3, 2020
@adguard-bot adguard-bot added the UI label Apr 3, 2020
@contribucious contribucious changed the title Add Vivaldi Snapshot & Sopranos to the list of supported browsers Add Vivaldi Snapshot and Vivaldi Sopranos to the list of supported browsers Apr 21, 2020
@contribucious
Copy link
Author

Yay! Freshly added!
I will close this issue therefore.
Thanks again to the team! 👍

AdGuard for Android

version 3.4 nightly 18 from April 21, 2020

[...]
[Other] Add Vivaldi Snapshot & Sopranos to the list of supported browsers: #3400
[...]

@contribucious
Copy link
Author

contribucious commented Apr 21, 2020

@Revertron Please add the Resolution: Done (or Resolution: Fixed) tag as needed, however. 👍

@adguard-bot adguard-bot added this to the 3.4 milestone Apr 22, 2020
@contribucious
Copy link
Author

@Revertron

According to my tests, you forgot to add com.vivaldi.browser.snapshot and com.vivaldi.browser.sopranos to pref.enforce.https.filtering to have HTTPS filtering active by default.

Tested OK once done manually (either by adding them manually to the pref.enforce.https.filtering list or by activating their option "HTTPS filtering" in the interface).

Can you confirm that? And if so, correct that? Thank you in advance. 👍


Environment: Passage from the last stable version (3.3.3) to the last beta version (3.4 beta 1) — not premium.

@contribucious
Copy link
Author

Regarding the post above:

 
Unlike Brave Beta, NOT fixed in 3.4 beta 2 in this case.
 

$ grep -n vivaldi adguard_3.4_beta-1_apk_extracted/enforce_https_filtering_apps.txt
33:com.vivaldi.browser
$ grep -n vivaldi adguard_3.4_beta-2_apk_extracted/enforce_https_filtering_apps.txt
33:com.vivaldi.browser

 
(cc @admitrevskiy Thanks in advance.)

@contribucious
Copy link
Author

@artemiv4nov Hello!

According to my tests, you forgot to add com.vivaldi.browser.snapshot and com.vivaldi.browser.sopranos to pref.enforce.https.filtering to have HTTPS filtering active by default.

Tested OK once done manually (either by adding them manually to the pref.enforce.https.filtering list or by activating their option "HTTPS filtering" in the interface).

↪️ Could you remedy this before beta 1? 👍

➡️ More generally, is there a particular reason why some little-known browsers (in beta, dev, etc.) are added to this list while more well-known ones (same type of version) are not?

Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants