improve guard and fix example

AdguardTeam · Nov 9, 2022 · 190bc2c · 190bc2c
1 parent 81bacc0
commit 190bc2c
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 6 deletions.
diff --git a/src/scriptlets/set-local-storage-item.js b/src/scriptlets/set-local-storage-item.js
@@ -40,7 +40,16 @@ import {
 /* eslint-enable max-len */
 
 export function setLocalStorageItem(source, key, value) {
-    if (!key || (!value && value !== '')) {
+    // eslint-disable-next-line no-console
+    const log = console.log.bind(console);
+
+    if (typeof key === 'undefined') {
+        log('Item key should be specified.');
+        return;
+    }
+
+    if (typeof value === 'undefined') {
+        log('Item value should be specified.');
         return;
     }
 

diff --git a/src/scriptlets/set-session-storage-item.js b/src/scriptlets/set-session-storage-item.js
@@ -39,7 +39,16 @@ import {
 /* eslint-enable max-len */
 
 export function setSessionStorageItem(source, key, value) {
-    if (!key || (!value && value !== '')) {
+    // eslint-disable-next-line no-console
+    const log = console.log.bind(console);
+
+    if (typeof key === 'undefined') {
+        log('Item key should be specified.');
+        return;
+    }
+
+    if (typeof value === 'undefined') {
+        log('Item value should be specified.');
         return;
     }
 

diff --git a/src/scriptlets/trusted-set-local-storage-item.js b/src/scriptlets/trusted-set-local-storage-item.js
@@ -45,17 +45,24 @@ import {
  * example.org#%#//scriptlet('trusted-set-local-storage-item', 'player.live.current.play', '$currentDate$')
  * ```
  *
- * 4. Set item without key or value
+ * 4. Set item without value
  * ```
- * example.org#%#//scriptlet('trusted-set-local-storage-item', '', '2644')
- *
  * example.org#%#//scriptlet('trusted-set-local-storage-item', 'ppu_main_none', '')
  * ```
  */
 /* eslint-enable max-len */
 
 export function trustedSetLocalStorageItem(source, key, value) {
-    if (!key || (!value && value !== '')) {
+    // eslint-disable-next-line no-console
+    const log = console.log.bind(console);
+
+    if (typeof key === 'undefined') {
+        log('Item key should be specified.');
+        return;
+    }
+
+    if (typeof value === 'undefined') {
+        log('Item value should be specified.');
         return;
     }