Improve googlesyndication-adsbygoogle — adsbygoogle.push

AdguardTeam · Oct 21, 2022 · 85a7677 · 85a7677
1 parent 932ff82
commit 85a7677
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/src/redirects/googlesyndication-adsbygoogle.js b/src/redirects/googlesyndication-adsbygoogle.js
@@ -32,7 +32,9 @@ export function GoogleSyndicationAdsByGoogle(source) {
                 for (const key of Object.keys(arg)) {
                     if (typeof arg[key] === 'function') {
                         try {
-                            arg[key].call();
+                            // https://github.com/AdguardTeam/Scriptlets/issues/252
+                            // argument "{}" is needed to fix issue with undefined argument
+                            arg[key].call(this, {});
                         } catch {
                             /* empty */
                         }

diff --git a/tests/redirects/googlesyndication-adsbygoogle.test.js b/tests/redirects/googlesyndication-adsbygoogle.test.js
@@ -69,8 +69,22 @@ test('Redirect testing', (assert) => {
 
     assert.strictEqual(window.adsbygoogle.length, undefined, 'adsbygoogle.length check');
     assert.strictEqual(window.adsbygoogle.push.length, 1, 'push.length check');
-    const pushCallback = () => {
-        assert.ok(true, 'callback was called');
+    const pushCallback = (arg) => {
+        try {
+            let check = false;
+            if (arg) {
+                check = true;
+            }
+            // Test for https://github.com/AdguardTeam/Scriptlets/issues/252
+            // If arg is not defined then error will be thrown
+            if (arg.whatever) {
+                arg.whatever = 1;
+            }
+            assert.strictEqual(check, true, 'callback was called');
+        } catch (error) {
+            const check = false;
+            assert.strictEqual(check, true, 'something went wrong');
+        }
     };
     const pushArg = {
         test: 'test',