Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

druid: update for shadowlands #399

Merged
merged 3 commits into from
May 15, 2022
Merged

druid: update for shadowlands #399

merged 3 commits into from
May 15, 2022

Conversation

luukvbaal
Copy link
Contributor

@luukvbaal luukvbaal commented May 14, 2022

Hi, I've been enjoying using this addon but finally got fed up with some of the missing data for my class since shadowlands, so I thought I would take a stab at updating it.

I also added rules for the covenant abilities Fleshcraft and Soulshape here in Common.lua, and Door of Shadows in AdiAddons/LibPlayerSpells-1.0#156.

@Rainrider
Copy link
Member

I removed the coventant related common rules and added those in LibPlayerSpells-1.0@c055234fec3a866a0a365afed2bfc2dba4edd552 . Soulshape's actual buff id depends on the chosen form and there are 27 of those, so the rule is working for the base form only for now (I don't see much benefit of adding all of those, you might create a custom rule for your toon for your specific buff combination though).

Thank you for your contribution, much appreciated.

@Rainrider Rainrider merged commit e233366 into AdiAddons:master May 15, 2022
@luukvbaal
Copy link
Contributor Author

Thanks for the fixes and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants