-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for AdoptOpenJDK 16 #793
Conversation
Now on staging server here. |
There is a typo in "If the heap size is 57 GB or larger, it will automatically enable compressed references". It automatically enables non-compressed references. |
Also, it should be "larger than 57GB", as 57GB exactly doesn't use "XL". |
@pshipton Fixed. |
and to be entirely accurate: |
@pshipton Fixed, too. |
Now on staging server here. |
1 similar comment
Now on staging server here. |
lgtm |
JEP 387 links to 386 |
@pshipton Fixed and thanks to your 🦅 eyes 😄 |
Actually, this link is to the draft docs It should refer to https://www.eclipse.org/openj9/docs/version0.25/ which doesn't work today but will work when the docs are published. Same with https://eclipse.github.io/openj9-docs/allocation/#compressed-references, it should be https://www.eclipse.org/openj9/docs/allocation/#compressed-references |
Now on staging server here. |
The fix for JEP 387 looks good, but it didn't show up on the staging server. |
Have changed the links as requested. |
|
||
### Removal of XL Variants of OpenJ9 | ||
|
||
So far, AdoptOpenJDK with Eclipse OpenJ9 came in two flavors: "normal" and "XL". The XL variant was purpose-built for workloads with very large heaps (hence the name). Thanks to recent improvements to OpenJ9, this distinction is no longer necessary. [AdoptOpenJDK 16 with Eclipse OpenJ9 is available as a single build that automatically switches between the normal and XL mode](https://eclipse.github.io/openj9-docs/version0.25/#single-build-for-compressed-references-and-non-compressed-references) depending on the configured heap size (`-Xmx` switch). If the heap size is larger than 57 GB, it will automatically enable non-compressed references, which corresponds to the old XL mode. On AIX and Linux with the metronome garbage collection policy (`-Xgcpolicy:metronome`), the threshold is at 25 GB instead of 57 GB. Next month, AdoptOpenJDK 8 and 11 with OpenJ9 will get the same capabilities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eclipse OpenJ9 came in two flavors: "normal" and "XL"
I'm in two minds over referring to normal
vs XL
instead of just normal and large. @pshipton is it ok to refer to the two variants that way? I'm not sure how often "XL" is used in the Openj9 docs like this. Perhaps we could use "normal" and "large heap" (XL)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, "Large Heap" is better since that is how the web pages refer to them, and the api uses "large".
Now on staging server here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching my review to an explicit "changes required" after my discussion above with Peter
Now on staging server here. |
The link https://www.eclipse.org/openj9/docs/allocation/#compressed-references/#compressed-references has an extra |
Now on staging server here. |
1 similar comment
Now on staging server here. |
lgtm, the link works now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little nit on http/https, and we have to bear in mind we're saying "thoroughly tested" when the new Alpine builds have not been as throroughly tested as the others, but I'm happy with this.
Now on staging server here. |
Co-authored-by: Stewart X Addison <[email protected]>
Now on staging server here. |
Fixes #741.