Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for AdoptOpenJDK 16 #793

Merged
merged 10 commits into from
Mar 19, 2021
Merged

Add release notes for AdoptOpenJDK 16 #793

merged 10 commits into from
Mar 19, 2021

Conversation

aahlenst
Copy link
Collaborator

Fixes #741.

@adoptopenjdk-github-bot

Now on staging server here.

2 similar comments
@adoptopenjdk-github-bot

Now on staging server here.

@adoptopenjdk-github-bot

Now on staging server here.

@pshipton
Copy link

There is a typo in "If the heap size is 57 GB or larger, it will automatically enable compressed references". It automatically enables non-compressed references.

@pshipton
Copy link

Also, it should be "larger than 57GB", as 57GB exactly doesn't use "XL".

@aahlenst
Copy link
Collaborator Author

@pshipton Fixed.

@pshipton
Copy link

and to be entirely accurate:
AIX® and Linux®: For the metronome garbage collection policy, the threshold is 25 GB.
So > 25GB with -Xgcpolicy:metronome

@aahlenst
Copy link
Collaborator Author

@pshipton Fixed, too.

@adoptopenjdk-github-bot

Now on staging server here.

1 similar comment
@adoptopenjdk-github-bot

Now on staging server here.

@pshipton
Copy link

lgtm

@pshipton
Copy link

JEP 387 links to 386

@aahlenst
Copy link
Collaborator Author

@pshipton Fixed and thanks to your 🦅 eyes 😄

@pshipton
Copy link

@adoptopenjdk-github-bot

Now on staging server here.

@pshipton
Copy link

pshipton commented Mar 12, 2021

The fix for JEP 387 looks good, but it didn't show up on the staging server.
Edit: now I see it.

@aahlenst
Copy link
Collaborator Author

Have changed the links as requested.

content/blog/adoptopenjdk-16-available/index.md Outdated Show resolved Hide resolved
content/blog/adoptopenjdk-16-available/index.md Outdated Show resolved Hide resolved

### Removal of XL Variants of OpenJ9

So far, AdoptOpenJDK with Eclipse OpenJ9 came in two flavors: "normal" and "XL". The XL variant was purpose-built for workloads with very large heaps (hence the name). Thanks to recent improvements to OpenJ9, this distinction is no longer necessary. [AdoptOpenJDK 16 with Eclipse OpenJ9 is available as a single build that automatically switches between the normal and XL mode](https://eclipse.github.io/openj9-docs/version0.25/#single-build-for-compressed-references-and-non-compressed-references) depending on the configured heap size (`-Xmx` switch). If the heap size is larger than 57 GB, it will automatically enable non-compressed references, which corresponds to the old XL mode. On AIX and Linux with the metronome garbage collection policy (`-Xgcpolicy:metronome`), the threshold is at 25 GB instead of 57 GB. Next month, AdoptOpenJDK 8 and 11 with OpenJ9 will get the same capabilities.
Copy link
Member

@sxa sxa Mar 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eclipse OpenJ9 came in two flavors: "normal" and "XL"

I'm in two minds over referring to normal vs XL instead of just normal and large. @pshipton is it ok to refer to the two variants that way? I'm not sure how often "XL" is used in the Openj9 docs like this. Perhaps we could use "normal" and "large heap" (XL)?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, "Large Heap" is better since that is how the web pages refer to them, and the api uses "large".

@adoptopenjdk-github-bot

Now on staging server here.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching my review to an explicit "changes required" after my discussion above with Peter

@adoptopenjdk-github-bot

Now on staging server here.

@karianna karianna added this to the March 2021 milestone Mar 14, 2021
@karianna karianna added the enhancement New feature or request label Mar 14, 2021
@pshipton
Copy link

The link https://www.eclipse.org/openj9/docs/allocation/#compressed-references/#compressed-references has an extra /#compressed-references

@adoptopenjdk-github-bot

Now on staging server here.

1 similar comment
@adoptopenjdk-github-bot

Now on staging server here.

@pshipton
Copy link

lgtm, the link works now.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little nit on http/https, and we have to bear in mind we're saying "thoroughly tested" when the new Alpine builds have not been as throroughly tested as the others, but I'm happy with this.

content/blog/adoptopenjdk-16-available/index.md Outdated Show resolved Hide resolved
@adoptopenjdk-github-bot

Now on staging server here.

2 similar comments
@adoptopenjdk-github-bot

Now on staging server here.

@adoptopenjdk-github-bot

Now on staging server here.

@adoptopenjdk-github-bot

Now on staging server here.

@aahlenst aahlenst merged commit 72c8589 into AdoptOpenJDK:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JDK 16 Release Announcement
5 participants