Pool and direct deal creation flow tests #969

0xDmitry · 2023-03-03T17:50:10Z

No description provided.

Staging into main

fallback added (#885)

fix error thrown (#890)

merge staging to main

Add LORDS to vouched pools (#921)

Hide Metagates pools (#923)

merge staging to main

* InvestorsModal now sortable by AmountInvested or UserAddress * Remove orderBy function from useAelinInvestors hook * Rename orderBy to newSortBy for clarity

* Fix default font size * Fix maintenance message * Fix history empty state * Fix nft selector * fix nft selector * Fix small font issues * Fix font size of the vest page

* Fix default font size * Upgrade to latest web3-onboard version * Fix merge conflict

Staging into Main

* Fix font size * fix loader

Improve some font sizes (#967)

vercel · 2023-03-03T17:50:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
aelin-ui-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 5, 2023 8:11pm

0xlinus · 2023-03-07T17:18:36Z

tests/e2e/builders/poolStepper.js

+    this.allowlistAddress = '0x0000000000000000000000000000000000000000'
+    this.allowlistAmount = 1


Can't we use faker to add some level of randomness?

0xlinus · 2023-03-07T17:25:22Z

tests/e2e/pages/aelin/create-pool.js

+    }
+  }
+
+  assertNoCapCheckBox(checked) {


All assertions should be done in the spec file. Leave this for simple getters and pool logic methods

Strange requirement. It will lead to a lot of repetitive checks and bloated spec files. What's wrong with aggregation of asserts in util functions like this one?

Now it looks pretty clean and makes sense. But as this gets bigger and more tests are added, this might get out of control will too many utils/helpers, and making the level of abstraction too high. Anyway this is not critical, we could leave like that and see if in the future we need a refactor

0xlinus · 2023-03-07T17:35:14Z

tests/e2e/pages/aelin/create-direct-deal.js

+    }
+  }
+
+  assertDetails(fakeDirectDeal, step = CreateDirectDealSteps.VestingSchedule, expected) {


I think that this is a bit overkill.. why dont just add the code for each test directly?
You will be adding more lines/less clean, but you will end up removing unnecessary abstraction imo.
And again... we are mixing concerns here.

Well, that's arguable... I see tests as a good source of requirements about how app should work, so readability is very helpful not only to write/fix them but also to onboard new contributors and discover use cases in general

But I agree that there are definitely a trade off between more readable but more complex code and less readable but more reliable code, so we just need to agree which path we want to lean to and what price to pay

0xlinus · 2023-03-07T18:10:07Z

I think this is very good overall... but there are a couple of things we need to decide how to tackle:

Not really important: Mixing concerns. I'd like to keep separated app Pages (for getting components or executing actions, like clicks, type, etc) from actual tests. That could get out of control pretty quickly and sometimes you have no idea what the test is actually doing. I understand the why you did it of course, makes perfect sense. I'm just concern about how this will play out in future tests and when this gets bigger.
Important: This takes a ridiculous amount of time. Although I 100% agree to refresh the page for each test to have a clean state, this takes too much. Maybe we could create a helper to reset all inputs or something diff... but refresh the page is definitely too much
Important 2: We should have left this clear before probably, but there are a lot of tests that are not reaaaaallly important. We should be adding E2E tests of flows that could potentially end up in a broken/wrong pool/deal causing $$ loss for the users. So I really don't mind if there are things that are not perfectly displayed in the summary component for example.
Not important 2: There are some flaky tests, most of them due to date mismatch.

…approve action) (#971)

…ss that vouches is a multisig on mainnet (#973)

* ethlizards design (#955) * add ethliz theme * fix blur effect * fix background * add pool ethlizards screen * fix review * fix modal and gradients * add ethlizrd logo * update logo * fix merge conflict * Ethlizards theme improvements * change ETHLIZARDS_VOUCHER_ENS value * Fix weird CI issue * tidy up * design improvements * tidy up * tidy up * remove stake section from sidebar * Add lizards to pool/deal creation boxes --------- Co-authored-by: James <[email protected]>

* remove stake section from sidebar * Sidebar - stake rollback

* attempt to fix CI issue (#1009) * Stats see more button redirects to pools filtered by network as well (#1004) * Stats see more button redirects to pools filtered by network as well * Remove unused sponsors/List component --------- Co-authored-by: Atatakai <[email protected]> * Add CONTRIBUTING.md (#1023) * Use IPFS Gateway as default option to get Merkle tree data (#1028) * Remove jest warnings issues (#1026) * Add Sepolia network (#1029) * Add Ethlizards theme (#1025) * ethlizards design (#955) * add ethliz theme * fix blur effect * fix background * add pool ethlizards screen * fix review * fix modal and gradients * add ethlizrd logo * update logo * fix merge conflict * Ethlizards theme improvements * change ETHLIZARDS_VOUCHER_ENS value * Fix weird CI issue * tidy up * design improvements * tidy up * tidy up * remove stake section from sidebar * Add lizards to pool/deal creation boxes --------- Co-authored-by: James <[email protected]> * Bring Stake section back to the Sidebar (#1027) * remove stake section from sidebar * Sidebar - stake rollback --------- Co-authored-by: Tanya <[email protected]> Co-authored-by: Atatakai <[email protected]> Co-authored-by: Dmitry <[email protected]> Co-authored-by: James <[email protected]>

* Lizards theme - Fix background image * fix grammar

* Fix Buy Aelin Optimism link * Fix

alextheboredape and others added 17 commits December 8, 2022 11:27

Merge pull request #874 from AelinXYZ/staging

1eb1f66

Staging into main

Merge pull request #887 from AelinXYZ/staging

34f6b9b

fallback added (#885)

Merge pull request #892 from AelinXYZ/staging

16107c3

fix error thrown (#890)

Merge pull request #903 from AelinXYZ/staging

0b4a501

merge staging to main

Merge pull request #907 from AelinXYZ/staging

a182512

merge staging to main

Merge pull request #919 from AelinXYZ/staging

5bb21db

merge staging to main

Merge pull request #922 from AelinXYZ/staging

334e67d

Add LORDS to vouched pools (#921)

Merge pull request #924 from AelinXYZ/staging

c1cf9fe

Hide Metagates pools (#923)

Merge pull request #935 from AelinXYZ/staging

c651a4f

merge staging to main

Merge pull request #950 from AelinXYZ/staging

5b675c5

merge staging to main

Refactor useVoucherAddress hook (#958)

d64bde2

InvestorsModal now sortable by AmountInvested or UserAddress (#956)

feb6685

* InvestorsModal now sortable by AmountInvested or UserAddress * Remove orderBy function from useAelinInvestors hook * Rename orderBy to newSortBy for clarity

Fix default font size (#962)

4762c72

* Fix default font size * Fix maintenance message * Fix history empty state * Fix nft selector * fix nft selector * Fix small font issues * Fix font size of the vest page

Upgrade to the latest version of the Web3-Onboard library (#963)

13f738b

* Fix default font size * Upgrade to latest web3-onboard version * Fix merge conflict

Merge pull request #966 from AelinXYZ/staging

90c13c7

Staging into Main

Improve some font sizes (#967)

3a2a7fe

* Fix font size * fix loader

Merge pull request #968 from AelinXYZ/staging

12b8a6c

Improve some font sizes (#967)

0xDmitry requested a review from 0xlinus March 3, 2023 17:50

0xDmitry self-assigned this Mar 3, 2023

vercel bot deployed to Preview – aelin-ui-v2 March 3, 2023 17:56 View deployment

0xlinus reviewed Mar 7, 2023

View reviewed changes

Fix timeline progress bars

b97ce8b

vercel bot deployed to Preview – aelin-ui-v2 March 13, 2023 17:36 View deployment

0xDmitry and others added 3 commits March 15, 2023 22:46

Add error message when holder does not have enough to fund the deal (…

68d4e90

…approve action) (#971)

Hadcode info about pools vesting ends (#972)

af57377

Filter vouched pools on any network other than mainnet when the addre…

0ba1a7a

…ss that vouches is a multisig on mainnet (#973)

0xDmitry and others added 28 commits May 11, 2023 20:54

Add Sepolia network (#1029)

6f3c0eb

Bring Stake section back to the Sidebar (#1027)

459736a

* remove stake section from sidebar * Sidebar - stake rollback

Fix Lizards header on mobile (#1032)

0f0a109

Merge branch 'main' into staging

8947f2b

Lizards theme - Fix background image (#1034)

ff91a90

* Lizards theme - Fix background image * fix grammar

change gas price (#1036)

7575b14

Fix Buy Aelin Optimism link (#1039)

cac0084

* Fix Buy Aelin Optimism link * Fix

added dockerfiles + some logic changes

493272e

improvements

e3fb97f

added workflow

a0eed35

added ci folder

8e8a555

added changes for local dev

65e390f

added goerli tokens

1fdeb06

added extra envs to add-envs script

2581801

no need for vercel deployment

587bb3f

fix envs export + ci warnings

e241672

added missing deps +fix ci try 2

9fd9f01

fixed linting

c9ac166

add mainnet token prov to envs

cc0e96e

added tests + fix synpress envs issue

7845bff

added dockerfiles + some logic changes

5f4b29e

added changes for local dev

553b680

added missing deps +fix ci try 2

fb4acdf

added tests + fix synpress envs issue

d286f2a

Pool and direct deal creation flow tests

7daee73

updated synpress + solved conflicts

9426456

0xlinus force-pushed the e2e-pool-and-direct-deal-creation-flows branch from 234f7a1 to 9426456 Compare June 5, 2023 20:04

vercel bot deployed to Preview – aelin-ui-v2 June 5, 2023 20:11 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pool and direct deal creation flow tests #969

Pool and direct deal creation flow tests #969

0xDmitry commented Mar 3, 2023

vercel bot commented Mar 3, 2023 •

edited

Loading

0xlinus Mar 7, 2023

0xlinus Mar 7, 2023

0xDmitry Mar 7, 2023

0xlinus Mar 7, 2023

0xlinus Mar 7, 2023

0xDmitry Mar 7, 2023

0xDmitry Mar 7, 2023 •

edited

Loading

0xlinus commented Mar 7, 2023

		this.allowlistAddress = '0x0000000000000000000000000000000000000000'
		this.allowlistAmount = 1

Pool and direct deal creation flow tests #969

Are you sure you want to change the base?

Pool and direct deal creation flow tests #969

Conversation

0xDmitry commented Mar 3, 2023

vercel bot commented Mar 3, 2023 • edited Loading

0xlinus Mar 7, 2023

Choose a reason for hiding this comment

0xlinus Mar 7, 2023

Choose a reason for hiding this comment

0xDmitry Mar 7, 2023

Choose a reason for hiding this comment

0xlinus Mar 7, 2023

Choose a reason for hiding this comment

0xlinus Mar 7, 2023

Choose a reason for hiding this comment

0xDmitry Mar 7, 2023

Choose a reason for hiding this comment

0xDmitry Mar 7, 2023 • edited Loading

Choose a reason for hiding this comment

0xlinus commented Mar 7, 2023

vercel bot commented Mar 3, 2023 •

edited

Loading

0xDmitry Mar 7, 2023 •

edited

Loading