Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Players kicked are not caught. #7

Closed
TheDeafCreeper opened this issue Jun 3, 2023 · 1 comment · Fixed by #14
Closed

Players kicked are not caught. #7

TheDeafCreeper opened this issue Jun 3, 2023 · 1 comment · Fixed by #14
Labels
bug Something isn't working patched The issue has been patched and should be fixed

Comments

@TheDeafCreeper
Copy link
Contributor

This does seem to be caused by the server being unregistered before the kick goes through, aka on server close. More testing needs to be done though.

Other potential issues:

  • Velocity's fallback interfering.

== COPIED FROM DISCORD ==

Both Kicked

[23:20:15 INFO]: RustyConnector:
[ws-1-713](ns1006130.ip-135-148-52.us:41054) ?///? woolsacre-game
[23:20:15 INFO]: RustyConnector:
[ws-1-713](ns1006130.ip-135-148-52.us:41054) ///// woolsacre-game
[23:20:15 INFO]: [connected player] TheDeafCreeper (/0.0.0.0:37016): kicked from server ws-1-713: Server closed
[23:20:15 INFO]: [server connection] TheDeafCreeper -> ws-1-713 has disconnected
[23:20:15 INFO]: [connected player] TheDeafCreeper (/0.0.0.02:37016) has disconnected: Server closed
[23:20:15 INFO]: [connected player] LogicalPlus (/0.0.0.0:56374): kicked from server ws-1-713: Server closed
[23:20:15 INFO]: [server connection] LogicalPlus -> ws-1-713 has disconnected
[23:20:15 INFO]: [connected player] LogicalPlus (/0.0.0.0:56374) has disconnected: Server closed

Only Me Kicked

[23:39:13 INFO]: [connected player] TheDeafCreeper (/0.0.0.0:9613): kicked from server ws-1-8219: Server closed
[23:39:13 INFO]: [server connection] TheDeafCreeper -> ws-1-8219 has disconnected
[23:39:13 INFO]: RustyConnector:
[ws-1-8219](ns1006130.ip-135-148-52.us:41057) ?///? woolsacre-game
[23:39:13 INFO]: RustyConnector:
[ws-1-8219](ns1006130.ip-135-148-52.us:41057) ///// woolsacre-game
[23:39:13 INFO]: [server connection] TheDeafCreeper -> lobby-1-1842 has connected
[23:39:13 INFO]: [connected player] LogicalPlus (/0.0.0.0:56519): kicked from server ws-1-8219: Server closed
[23:39:13 INFO]: [server connection] LogicalPlus -> ws-1-8219 has disconnected
[23:39:13 INFO]: [connected player] LogicalPlus (/0.0.0.0:56519) has disconnected: Server closed
[23:39:13 INFO] [rustyconnector-velocity]: Cannot invoke "group.aelysium.rustyconnector.plugin.velocity.lib.module.PlayerServer.getFamilyName()" because "oldServer" is null
@nathan-i-martin
Copy link
Contributor

nathan-i-martin commented Jun 3, 2023 •
edited
Loading

A fix for this issue has been added in 9af5991
Feel free to test.

@nathan-i-martin nathan-i-martin added the bug Something isn't working label Jun 3, 2023
@nathan-i-martin nathan-i-martin added the patched The issue has been patched and should be fixed label Jun 15, 2023
This was referenced Jun 19, 2023
Merged
Merged
nathan-i-martin added a commit that referenced this issue Jun 19, 2023
@nathan-i-martin
Merge pull request #14 from Aelysium-Group/development
130c41d 
Changes:
- Fix #7 
- Fix #11 (Commands must be executed as `rustyconnector-paper:rc` on sub-servers now)
- Optimize Redis Publisher (Messages should publish instantly now)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working patched The issue has been patched and should be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Development Aelysium-Group/rusty-connector
2 participants
@TheDeafCreeper @nathan-i-martin