-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding WNC sentence type #110
Conversation
I would like to propose adding the WNC sentence type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a minor thing regarding the docs and I don't have any feedback on the actual implementation.
Once again thank you for you contribution!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 77.51% 77.62% +0.11%
==========================================
Files 33 34 +1
Lines 1223 1247 +24
==========================================
+ Hits 948 968 +20
- Misses 275 279 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so I took a look again this morning and I also remembered a few things.
Please add these things to the PR:
- A feature for the sentence to be enabled in Cargo.toml (enabled for
waypoint
feature too) - add the example sentence in
all_supported_messages.rs
test
I've also suggested changes to the docs to resemble other places. I do wish to make the docs consistent across the crate eventually.
I've also fixed the MSRV and all the warnings so you should be good to go if your code follows rustfmt/clippy. |
No description provided.